Repository navigation
Conversation
The release build checked out the pushed tag by its short name, and actions/checkout resolves a short name to a branch before a tag, so a branch named like the tag would be built in its place. Check out refs/tags/<tag>, confirm that HEAD is the tagged commit before building, and test ancestry against refs/remotes/origin/main so that a tag named origin/main cannot stand in for the branch.
Install cargo-edit 0.13.13 with --locked before the checkout, so every run builds the same dependency tree and no repository credentials are on disk while it builds. The checkout no longer persists the token; the step that creates the release branch receives it and creates the branch through the API, like the steps that commit to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
release.ymlrefs/tags/<tag>and confirms thatHEADis the tagged commit before building. A short name letsactions/checkoutresolve a branch of the same name first.refs/remotes/origin/main.version-up.ymlcargo-edit0.13.13 with--lockedbefore the checkout, so every run builds the same dependency tree.Testing
actionlinton both workflows.