Repository navigation
Treat pending Monerium profiles as approved on the sandbox - #1434
Merged
Merged
Conversation
Monerium's sandbox has not approved any white-label profile in 12 days, which blocks the partner's end-to-end registration test. A pending profile can already link addresses and receive an IBAN, so the keeper's approval gate was the only blocker. Keyed on SANDBOX_ENABLED like the sandbox auto-activation; production keeps waiting for approved.
The security spec, the architecture doc and ADR-0007 said every partner registration waits for an approved profile. The sandbox now proceeds on pending, so the spec carries the scope, the approved KYB mirror and the refund caveat, and the architecture doc's auto-activation scope matches the code (sandbox only, not everything outside production).
The sandbox walkthrough said the provider approves each test profile before Vortex deploys anything. Partners testing registrations now see a pending profile proceed, and need to know that created, incomplete and in-review profiles still wait and that payouts can be refused until the provider approves the profile.
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi canceled.
|
✅ Deploy Preview for vrtx-dashboard canceled.
|
…box-approve-pending # Conflicts: # docs/api/pages/14-managed-profiles.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The B2B keeper deploys a client's contract for a partner registration only once Monerium reports the profile as
approved. Monerium's sandbox has not approved any white-label profile since our test companies were submitted on 7 Oct, and Monerium has not explained how sandbox approval works. That blocks the partner's end-to-end registration test on the sandbox. Everything after the approval gate already works for a pending profile: it can link addresses and gets an IBAN within seconds (found on 8 Oct).What changes
SANDBOX_ENABLED=true), the registration processor treats a profile Monerium reports aspendingas approved, and logs that once per registration. Created, incomplete and in-review profiles still wait, rejected and closed ones are still rejected, and every other environment keeps waiting forapproved. The app already refuses to boot withSANDBOX_ENABLED=trueunlessDEPLOYMENT_ENV=sandbox.recovery_failed, as before. The consumer onramp's own approval check is untouched.Docs
Security spec invariant 12 (plus a checklist line), the architecture doc's registration paragraph (which also corrects "outside production the account activates" to the sandbox-only behaviour the code, spec and ADR-0007 describe), a dated note on ADR-0007 decision 3, and the partner page's sandbox specifics, integration steps and waiting-reason table, with the matching OpenAPI description. The wire-contract snapshot is unchanged.
Tests
registration.test.ts: a pending profile in the sandbox deploys, maps and logs once (fails on the old code); outside the sandbox a pending profile waits, and in the sandbox created, incomplete and in-review profiles wait (guards against a broader override; checked by mutation). Full apps/api suite 2314 pass, 0 fail; typecheck, verify, wire-contract, docs check and the api build pass.Both this PR and #1429 edit the B2B security spec and architecture doc in different paragraphs; whichever merges second may need a merge from staging.