Skip to content

ci: install the ros extra so test_ros.py actually runs - #111

Merged
petercorke merged 1 commit into
mainfrom
ci/install-ros-extra
Oct 3, 2026
Merged

petercorke merged 1 commit into
mainfrom
ci/install-ros-extra

Conversation

@petercorke

Copy link
Copy Markdown
Owner

Summary

Fixes the CI half of #80: rosbags, roslibpy and websockets (the ros extra) were never installed in CI, so tests/test_ros.py was largely skipped — including TestRosBagRos1/2, TestRosTopicLive and the three open3d-gated test_publish_pointcloud_* tests.

Adds an Install ros extra step on the same Ubuntu / OpenCV 5 legs that already install open3d (all Python versions).

Verified locally

Clean isolated venv (Python 3.12, OpenCV 5.0, open3d 0.20, .[dev,tool,ros]):

  • tests/test_ros.py: 63 passed, 3 skipped without open3d; the 3 pointcloud-publish tests pass with it.
  • Full suite: 999 passed, 37 skipped (CI was 942 passed, 94 skipped).

Notes

Checklist

  • PR title follows Conventional Commits
  • Tests pass locally
  • CI green on all legs

🤖 Generated with Claude Code

rosbags, roslibpy and websockets were never installed in CI, so the whole
ROSBag / ROSTopic test suite (including the three open3d-gated pointcloud
publish tests) was silently skipped. Install .[ros] on the same
Ubuntu/OpenCV 5 legs that already install open3d.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@petercorke
petercorke merged commit f09f48e into main Oct 3, 2026
35 checks passed
@petercorke
petercorke deleted the ci/install-ros-extra branch October 3, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant