ci: install the ros extra so test_ros.py actually runs - #111
Merged
Merged
Conversation
rosbags, roslibpy and websockets were never installed in CI, so the whole ROSBag / ROSTopic test suite (including the three open3d-gated pointcloud publish tests) was silently skipped. Install .[ros] on the same Ubuntu/OpenCV 5 legs that already install open3d. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI half of #80:
rosbags,roslibpyandwebsockets(therosextra) were never installed in CI, sotests/test_ros.pywas largely skipped — includingTestRosBagRos1/2,TestRosTopicLiveand the three open3d-gatedtest_publish_pointcloud_*tests.Adds an
Install ros extrastep on the same Ubuntu / OpenCV 5 legs that already install open3d (all Python versions).Verified locally
Clean isolated venv (Python 3.12, OpenCV 5.0, open3d 0.20,
.[dev,tool,ros]):tests/test_ros.py: 63 passed, 3 skipped without open3d; the 3 pointcloud-publish tests pass with it.Notes
roslibpypulls in Twisted/Autobahn, so a Python 3.13/3.14 leg could in principle fail to install it; CI on this PR will show that.Checklist
🤖 Generated with Claude Code