fix: remove labeltool console script whose module was never committed - #118
Merged
Merged
Conversation
… never committed (#117) pyproject.toml has declared labeltool = machinevisiontoolbox.bin.labeltool:main since 3735f96, but bin/labeltool.py was never committed, so the published 2.4.0 wheel installs a 'labeltool' command that fails with ModuleNotFoundError. Remove the entry point until the tool exists; the intended LabelMe region selector is tracked in #117. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…d it (#117) Would have caught the missing labeltool module before 2.4.0 shipped. Note it only fails in a clean checkout (as in CI): on a dev machine an untracked labeltool.py satisfies find_spec, which is how the bug went unnoticed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 7 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlhas declaredlabeltool = machinevisiontoolbox.bin.labeltool:mainsince 3735f96 (2026-04), butbin/labeltool.pywas never committed. I checked the published 2.4.0 wheel on PyPI: it listslabeltoolinentry_points.txtbut contains nolabeltool.py, so the installedlabeltoolcommand fails withModuleNotFoundErrorfor every user.This PR removes the entry point so the next release stops shipping a broken command, and adds a test so it can't recur. The intended tool (a region selector that writes LabelMe JSON) is tracked in #117; the only local
labeltool.pyis an oldimtoolcopy, not that tool, so it is deliberately not committed.Release note: this
fix:should make release-please propose a 2.4.1.Test
tests/test_entry_points.pyparses[project.scripts]and checks every module can be found (regex, nottomllib, because the package supports Python 3.10). Caveat I want to be upfront about: this only fails in a clean checkout. On a dev machine an untrackedlabeltool.pysatisfies the check, which is exactly how the bug went unnoticed. CI is a clean checkout, so CI is where it bites.Verification
git archiveof this commit: 5 console scripts (bagtool,imtool,mvtbtool,ocrtool,tagtool), each resolving to a module inside the wheel.main: fails, reporting['labeltool']. Clean checkout of this branch: passes. Also passes in the working tree on OpenCV 4.14 and 5.0 (2 passed).Closes the broken-entry-point half of #45; the rest of #45 (untracked files) continues separately.
Checklist
🤖 Generated with Claude Code