Repository navigation
fix(dashboard): contain malformed request targets (CORE-213) #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PrzemekGalarowicz
wants to merge
1
commit into
main
Choose a base branch
from
codex/core-213-ph11-malformed-target
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the shutdown assertion platform-aware.
The supplied Windows platform smoke run receives the expected
400responses, then records{code: null, signal: "SIGTERM"}afterstopCli. This unconditional exit-code assertion failsnpm test.Check the supported shutdown result for each platform. Retain the exit-code-0 assertion where graceful SIGTERM shutdown is supported, and validate the expected signal result on Windows. Keep the malformed-target and process-liveness assertions unchanged.
GitHub Actions: node-latest / 1_Platform smoke (windows-latest, node floor).txt
[error] 336-336: npm test (vitest run) failed: the test “AC: malformed request targets do not stop the built CLI and SIGTERM exits 0” expected the CLI exit code to be 0, but received null; the process exited via SIGTERM.
GitHub Actions: node-latest / Platform smoke (windows-latest, node floor)
[error] 336-336: The
npm teststep (runningvitest run) failed: the test “AC: malformed request targets do not stop the built CLI and SIGTERM exits 0” expected the CLI exit code to be 0, but received null with signal SIGTERM.GitHub Check: Platform smoke (windows-latest, node floor)
[failure] 336-336: src/cli/phargus-serve-cli.ac1.integration.test.ts > phargus CLI: malformed dashboard requests > AC: malformed request targets do not stop the built CLI and SIGTERM exits 0
AssertionError: stdout:
stderr:
phargus: dashboard at http://127.0.0.1:50342
phargus: input ended; still serving the collected data (Ctrl-C to stop)
phargus: counts: decoder.invalid=0 decoder.oversized=0 collector.ignored=0 dashboard.droppedEvents=0
notes:
exit: {"code":null,"signal":"SIGTERM"}: expected null to be +0 // Object.is equality
0
null
❯ src/cli/phargus-serve-cli.ac1.integration.test.ts:336:54
Source: Pipeline failures