Skip to content

fix(dashboard): require strong remote tokens (CORE-215) - #133

Open
PrzemekGalarowicz wants to merge 1 commit into
codex/core-213-ph11-malformed-targetfrom
codex/core-215-token-minimum
Open

PrzemekGalarowicz wants to merge 1 commit into
codex/core-213-ph11-malformed-targetfrom
codex/core-215-token-minimum

Conversation

@PrzemekGalarowicz

Copy link
Copy Markdown
Member

What this changes

  • Require at least 16 characters for dashboard tokens on non-loopback hosts and reject short secrets before binding.
  • Cover CLI, direct server API, and end-to-end startup behavior; update access guidance and threat model.

Linear: CORE-215

Checks

  • format:check
  • lint
  • typecheck
  • test (166 files, 347 tests)
  • build
  • check:exports

Node 24.13.1.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

pharn

🛡️ pharn-ci · ⚠️ Warn

Warning

Warn · Diff coverage of this change is 100% against a threshold of 80%; 35 agent setup files found.

Verdict Diff coverage Test integrity Agent setup
⚠️ Warn 100% (threshold 80%) none (block) 35 files

🧪 Diff coverage

▰▰▰▰▰▰▰▰▰▰▰▰▰▰▰▰▰▰▰▰ 100%

100% of changed lines covered (4/4, threshold 80%)

Changed files (2)
File Coverage Covered Uncovered lines
src/cli/args.ts 100% 2/2
src/dashboard/server.ts 100% 2/2

🔍 Test integrity

No test-integrity findings (mode: block).

  • ⚠️ Tests exercise changes — 2 of 3 changed source files are not imported by a test file this change adds or modifies.
    • Hint: Add or update a test that imports each listed file and asserts on the changed behaviour, or say in the PR why no test changes. This is a warning only.
Not exercised: 2 files
  • src/cli/usage.ts
  • src/dashboard/server.ts
Tests changed: +7 −0 ~1
Test file Added Removed Modified Renamed
src/cli/args.allowed-host.test.ts 0 0 1 0
src/cli/args.token-length.test.ts 3 0 0 0
src/cli/phargus-serve-cli.ac3.integration.test.ts 2 0 0 0
src/dashboard/dashboard-token-length.test.ts 2 0 0 0

🤖 Agent setup (35 files)

Agent setup: 35 files · claude-code

Agent setup files (35)
Path Kind
.claude/agents/pharn-review-lens.md claude-agent
.claude/agents/pharn-stage.md claude-agent
.claude/commands/pharn-build.md claude-command
.claude/commands/pharn-grill.md claude-command
.claude/commands/pharn-loop-close.md claude-command
.claude/commands/pharn-loop-quick.md claude-command
.claude/commands/pharn-loop.md claude-command
.claude/commands/pharn-memory-promote.md claude-command
.claude/commands/pharn-plan.md claude-command
.claude/commands/pharn-regress.md claude-command
.claude/commands/pharn-review.md claude-command
.claude/commands/pharn-ship-close.md claude-command
.claude/commands/pharn-ship-quick.md claude-command
.claude/commands/pharn-ship-stages.md claude-command
.claude/commands/pharn-ship.md claude-command
.claude/commands/pharn-spec.md claude-command
.claude/commands/pharn-supervise.md claude-command
.claude/commands/pharn-test.md claude-command
.claude/commands/pharn-triage.md claude-command
.claude/commands/pharn-verify.md claude-command
.claude/hooks/enforce-writes-scope.cjs claude-hook
.claude/hooks/protect-trusted-paths.cjs claude-hook
.claude/hooks/require-loop-record.cjs claude-hook
.claude/hooks/set-writes-scope.cjs claude-hook
.claude/settings.json claude-settings
.claude/skills/phargus-diagnose claude-skill
.claude/skills/phargus-memory claude-skill
.claude/skills/phargus-rules claude-skill
.claude/skills/phargus-setup claude-skill
.claude/skills/phargus-verify claude-skill
.claude/skills/pharn-ci-cover claude-skill
.claude/skills/pharn-ci-explain claude-skill
.claude/skills/pharn-ci-install claude-skill
.claude/skills/pharn-cli claude-skill
CLAUDE.md claude-md

pharn-ci 0.10.0 · report schema v2 · coverage format lcov

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant