Skip to content

docs(limits,threat-model): true statements about what pharn deletes (C4.2, CORE-175) - #420

Merged
PrzemekGalarowicz merged 1 commit into
mainfrom
przemek/core-175-limits-threat-model
Nov 17, 2026
Merged

PrzemekGalarowicz merged 1 commit into
mainfrom
przemek/core-175-limits-threat-model

Conversation

@PrzemekGalarowicz

Copy link
Copy Markdown
Member

Linear: CORE-175 (epic CORE-153). Follow-up to #416, which merged before the human-owned files could be patched.

LIMITS.md and THREAT-MODEL.md are human-owned and hook-protected. The maintainer applied these edits with a patch script; this PR only commits them.

  • LIMITS.md §1d: removes the false "update never deletes" and the unrelated src/commands/update.ts:452 citation. A renamed file's old copy stays on disk as an orphan; update deletes only a dropped capability's directory (deleteCapabilityDir, src/lib/capability-dir.ts). Links docs/reference/deletes.md.
  • LIMITS.md §1d backstop: "reports nothing" → names it in its ORPHANED note (as pharn status does).
  • THREAT-MODEL.md: "pharn deletes nothing outside the user's project" → outside the project pharn deletes only the temporary download directory it created itself (docs/reference/deletes.md).

Acceptance: grepping README.md, docs/, LIMITS.md and THREAT-MODEL.md for "never delete", "nothing deletes" and "only thing … deletes" now finds only true statements.

🤖 Generated with Claude Code

…C4.2, CORE-175)

LIMITS.md §1d: a renamed file's old copy stays on disk as an orphan;
`update` deletes only the directory of a capability it drops
(deleteCapabilityDir), never a file inside one it keeps. The unrelated
src/commands/update.ts:452 citation is gone, and the backstop no longer
says `update` reports nothing: the ORPHANED note names it.

THREAT-MODEL.md: outside the project pharn deletes only the temporary
download directory it created itself, not "nothing".

Both link docs/reference/deletes.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f52c23e and 414bb13.

Files selected for processing: 2

  • LIMITS.md
  • THREAT-MODEL.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

pharn

🛡️ pharn-ci · ✅ Pass

Tip

Pass · This change adds no coverable lines; 29 agent setup files found.

Verdict Diff coverage Test integrity Agent setup
✅ Pass no coverable lines none (block) 29 files

🧪 Diff coverage

No coverable lines changed.

🔍 Test integrity

No test-integrity findings (mode: block).

💬 Messages (1)

  • ℹ️ NO_COVERABLE_CHANGES No added lines are tracked by the coverage report; nothing to measure.
    • Hint: Nothing to do if the change has no code; otherwise check that the coverage report includes the changed files.

🤖 Agent setup (29 files)

Agent setup: 29 files · claude-code

Agent setup files (29)
Path Kind
.claude/commands/pharn-dev-build.md claude-command
.claude/commands/pharn-dev-eval.md claude-command
.claude/commands/pharn-dev-grill.md claude-command
.claude/commands/pharn-dev-memory-promote.md claude-command
.claude/commands/pharn-dev-plan.md claude-command
.claude/commands/pharn-dev-regress.md claude-command
.claude/commands/pharn-dev-review.md claude-command
.claude/commands/pharn-dev-ship.md claude-command
.claude/commands/pharn-dev-verify.md claude-command
.claude/hooks/enforce-writes-scope.cjs claude-hook
.claude/hooks/enforce-writes-scope.test.cjs claude-hook
.claude/hooks/git-worktree-fixture.cjs claude-hook
.claude/hooks/protect-trusted-paths.cjs claude-hook
.claude/hooks/protect-trusted-paths.test.cjs claude-hook
.claude/hooks/session-root.cjs claude-hook
.claude/hooks/session-root.test.cjs claude-hook
.claude/hooks/set-writes-scope.cjs claude-hook
.claude/hooks/set-writes-scope.test.cjs claude-hook
.claude/settings.json claude-settings
.claude/skills/phargus-diagnose claude-skill
.claude/skills/phargus-memory claude-skill
.claude/skills/phargus-rules claude-skill
.claude/skills/phargus-setup claude-skill
.claude/skills/phargus-verify claude-skill
.claude/skills/pharn-ci-cover claude-skill
.claude/skills/pharn-ci-explain claude-skill
.claude/skills/pharn-ci-install claude-skill
.claude/skills/pharn-cli claude-skill
CLAUDE.md claude-md

pharn-ci 0.10.0 · report schema v2 · coverage format lcov

@PrzemekGalarowicz
PrzemekGalarowicz merged commit a844f7a into main Nov 17, 2026
15 checks passed
@PrzemekGalarowicz
PrzemekGalarowicz deleted the przemek/core-175-limits-threat-model branch November 17, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant