Repository navigation
docs(limits,threat-model): true statements about what pharn deletes (C4.2, CORE-175) - #420
Merged
Merged
Conversation
…C4.2, CORE-175) LIMITS.md §1d: a renamed file's old copy stays on disk as an orphan; `update` deletes only the directory of a capability it drops (deleteCapabilityDir), never a file inside one it keeps. The unrelated src/commands/update.ts:452 citation is gone, and the backstop no longer says `update` reports nothing: the ORPHANED note names it. THREAT-MODEL.md: outside the project pharn deletes only the temporary download directory it created itself, not "nothing". Both link docs/reference/deletes.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
🛡️ pharn-ci · ✅ PassTip Pass · This change adds no coverable lines; 29 agent setup files found.
🧪 Diff coverageNo coverable lines changed. 🔍 Test integrityNo test-integrity findings (mode: block). 💬 Messages (1)
🤖 Agent setup (29 files)Agent setup: 29 files · claude-code Agent setup files (29)
pharn-ci 0.10.0 · report schema v2 · coverage format lcov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: CORE-175 (epic CORE-153). Follow-up to #416, which merged before the human-owned files could be patched.
LIMITS.md and THREAT-MODEL.md are human-owned and hook-protected. The maintainer applied these edits with a patch script; this PR only commits them.
LIMITS.md§1d: removes the false "updatenever deletes" and the unrelatedsrc/commands/update.ts:452citation. A renamed file's old copy stays on disk as an orphan;updatedeletes only a dropped capability's directory (deleteCapabilityDir,src/lib/capability-dir.ts). Linksdocs/reference/deletes.md.LIMITS.md§1d backstop: "reports nothing" → names it in itsORPHANEDnote (aspharn statusdoes).THREAT-MODEL.md: "pharn deletes nothing outside the user's project" → outside the project pharn deletes only the temporary download directory it created itself (docs/reference/deletes.md).Acceptance: grepping README.md, docs/, LIMITS.md and THREAT-MODEL.md for "never delete", "nothing deletes" and "only thing … deletes" now finds only true statements.
🤖 Generated with Claude Code