Repository navigation
feat(hooks): set-writes-scope --from-plan names and refuses a ## Files item it cannot scope (7.22.0) - #458
Merged
Conversation
…annot scope, naming each one The maintainer's patch (control surface, fix #2), committed before the build anchors (L68), plus the GATE-1-approved PLAN for setter-dropped-bullets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n took 7.20.0) The maintainer's patch (control surface), committed before the build anchors (L68). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… PLAN.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fuse the plan (setter-dropped-bullets) Build of the GATE-1-approved PLAN: the setter's tests, the three floor tests that fed it a glob, the plan commands' --check guidance, the comments and ac-tests.md sentence that said the setter drops such an item, the writes-scope guide, and the version bump. Includes REGRESSION.md / regression-report.json (no-regressions) and the independent review's fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dropped-bullets # Conflicts: # CHANGELOG.md
…n took 7.21.0); PLAN build round 2 The maintainer's patch (control surface), committed before build round 2's anchor (L68). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er-dropped-bullets REVIEW.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
🛡️ pharn-ci · ❌ FailCaution Fail · Diff coverage of this change is 100% against a threshold of 100%; 1 test-integrity finding; 106 agent setup files found.
🧪 Diff coverage
100% of changed lines covered (47/47, threshold 100%) Changed files (5)
🔍 Test integrity
💬 Messages (3)
🤖 Agent setup (106 files)Agent setup: 106 files · claude-code Agent setup files (106)
pharn-ci 0.10.0 · report schema v2 · coverage format lcov |
…n and SHIP.md (GATE 2) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
set-writes-scope.cjs --from-plannow refuses a plan whose## Filesholds an item it cannot scope (*,?,<,>, or an empty item), exits 1, writes nothing, and names every such item with its reason and the count (2 of 37 \## Files` item(s) … cannot be scoped`). Before, it dropped them without a word and printed the smaller count. This was found three times (L37, L71, the CORE-90 ship) and is the plan-time check L20 and L71 asked for. Ships as 7.22.0.--check(which/pharn-planand/pharn-dev-planrun at plan time) and in a build's Step 0, so--checkstill predicts Step 0. No opt-in: such an item never granted a write.--from-frontmatteris unchanged (its placeholders resolve through--target).d1793d20,60a2af53,843212ab.Changed
2 of 37), JSON quoting. 4 of the new tests fail on the old setter; the 5th is a control.check-ac-tests,check-build-completeparity,stage-verify)./pharn-planand/pharn-dev-plan--checkguidance, the writes-scope guide,ac-tests.md, and floor comments that said the setter "drops" such an item.pharn-install.jsonregenerated; SKILLS_VERSION 7.21.0 → 7.22.0; CHANGELOG## [7.22.0].Evidence
docs/capabilities/**item);entry-run-as-base-evidencereads2 of 37, exactly L71./pharn-dev-regress: no-regressions (194 outside test files, 6648 tests each side,validate, the trust-fence pair)./pharn-dev-verify: see.dev/features/setter-dropped-bullets/VERIFY.md.REVIEW.md).Bounds (P0)
A character-membership test in a Bash-run program (
pharn/LIMITS.md §6). A literal path the build never writes still passes. The message escapes C0 controls but not C1, DEL or bidi. Some unchanged sentences still say the hook "drops" such an entry (listed in the CHANGELOG); rewording them is a follow-up.Not merged: the merge is the maintainer's call.
🤖 Generated with Claude Code