Conversation
petk
reviewed
Aug 30, 2026
petk
reviewed
Aug 30, 2026
petk
approved these changes
Aug 30, 2026
Member
There was a problem hiding this comment.
I think this should work ok (if the additional cross-compilation variable isn't an issue - php-src requires a lot of cross-compilation adjustments, otherwise). I can't test this ATM. And probably would be good to have @bukka glance over these a bit also.
Detect epoll_pwait2 by checking for ENOSYS/ENOTSUP errno before defining HAVE_EPOLL_PWAIT2
marc-mabe
force-pushed
the
fix_HAVE_EPOLL_PWAIT2
branch
from
August 31, 2026 07:08
49a5dfd to
c733497
Compare
Member
|
I would prefer to do runtime fallback like we do for copy_file_range . That should be more reliable and the overhead is negligible. |
Member
|
That's done in #23825 . It should be safer. |
Contributor
Author
|
Agree thanks @bukka |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect epoll_pwait2 by checking for ENOSYS/ENOTSUP errno before defining HAVE_EPOLL_PWAIT2
Without this additional check HAVE_EPOLL_PWAIT2 got defined on my i386 container but failing constantly with ENOTSUP.
(via
Mac -> Lima -> Ubuntu + qemu -> docker (linux/amd64) -> PKG_CONFIG_PATH/CFLAGS/LDFLAGS to i386-linux-gnu/-m32🙈 )