Conversation
bzopen() with a stream argument, and the wrapper fallback in _php_stream_bz2open(), pass the stream's own descriptor to BZ2_bzdopen(). bzlib takes ownership of it and closes it in BZ2_bzclose(), after which the inner stream close closes the same descriptor number again. The bz2 stream also keeps a raw pointer to the inner stream while holding a reference on its resource only, so closing the inner stream with fclose() left a dangling pointer that the bz2 close dereferenced, while bzlib kept using a descriptor number that could already belong to another file. Hand bzlib a duplicate of the descriptor and resolve the inner stream from its resource on close, so a closed inner stream is skipped.
bukka
force-pushed
the
bz2_bzdopen_dup
branch
from
September 21, 2026 14:34
ae506de to
1a0e7a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bzopen() with a stream argument, and the wrapper fallback in _php_stream_bz2open(), pass the stream's own descriptor to BZ2_bzdopen(). bzlib takes ownership of it and closes it in BZ2_bzclose(), after which the inner stream close closes the same descriptor number again. The bz2 stream also keeps a raw pointer to the inner stream while holding a reference on its resource only, so closing the inner stream with fclose() left a dangling pointer that the bz2 close dereferenced, while bzlib kept using a descriptor number that could already belong to another file.
Hand bzlib a duplicate of the descriptor and resolve the inner stream from its resource on close, so a closed inner stream is skipped.