Conversation
Girgias
reviewed
Sep 22, 2026
Comment on lines
-58
to
-63
| ValueError: flock(): Argument #2 ($operation) must be one of LOCK_SH, LOCK_EX, or LOCK_UN | ||
| --- Iteration 1 --- | ||
| ValueError: flock(): Argument #2 ($operation) must be one of LOCK_SH, LOCK_EX, or LOCK_UN | ||
| --- Iteration 2 --- | ||
| ValueError: flock(): Argument #2 ($operation) must be one of LOCK_SH, LOCK_EX, or LOCK_UN | ||
| --- Iteration 3 --- |
Member
There was a problem hiding this comment.
Are these condition still tested somewhere?
Contributor
Author
There was a problem hiding this comment.
Semantically, in flock.phpt yes. ZPP in integer, yes. Exact flock(), no.
Comment on lines
+30
to
34
| /*8*/ true, | ||
| false, | ||
| TRUE, | ||
| FALSE, | ||
|
|
Member
There was a problem hiding this comment.
We probably should get rid of these duplicate tests too, same with strings where HEREDOC/NOWDOCS/single quote/double quotes are tested
Contributor
Author
There was a problem hiding this comment.
Removed TRUE/FALSE. Okay to doing the coercion/string stuff a separate PR as you mention below.
Comment on lines
72
to
-75
| "0", | ||
| TRUE, | ||
| FALSE, | ||
| "string12", |
Member
There was a problem hiding this comment.
In some way the coercion is also a ZPP test, but happy to punt this to another PR.
NickSdot
force-pushed
the
test/hardening/ext-standard-review
branch
from
September 22, 2026 09:20
ce1b631 to
e66b976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested in #23136 (review), cc @Girgias