Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-23842.
skipLazyInitialization()reads the property default straight out ofce->default_properties_table. Under shared-memory opcache the class entry is immutable and a default that references a class constant stays an unresolved AST there; the resolved value lives in the class's mutable data. So the method copied anIS_CONSTANT_ASTzval into the object slot, and the property then held something that is not a valid value of its declared type.var_dump()on it printsUNKNOWN:0, and a typed return over it throws aTypeError.CE_DEFAULT_PROPERTIES_TABLE()picks the mutable table when there is one, which is what the rest of the lazy object code already does inzend_lazy_object_mark_as_initialized()andzend_lazy_object_init().property_get_default()still reads the raw field, butgetDefaultValue()resolves the AST afterwards, so it is not affected.The diagnosis and the one-line patch are DirkTrunkstar's, from the issue.