Conversation
pdo_stmt_do_next_rowset() dropped the return value of pdo_stmt_describe_columns(), so a driver whose describer failed after the rowset advance left columns[] partially initialized while nextRowset() still reported success, and the next fetch read that incomplete state. Check the result, as pdo_stmt_do_execute(), do_fetch() and PDO::prepare() already do. No test: odbc_stmt_describe() fails when SQLDescribeCol() or SQLColAttribute() does, which needs a server driven into that state, and the bundled sqlite describer only fails for a column index past its own count, which the describe loop never passes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdo_stmt_do_next_rowset() dropped the return value of pdo_stmt_describe_columns(), so a driver whose describer failed after the rowset advance left columns[] partially initialized while nextRowset() still reported success, and the next fetch read that incomplete state. pdo_stmt_do_execute(), do_fetch() and PDO::prepare() already check it. No test: odbc_stmt_describe() fails when SQLDescribeCol() or SQLColAttribute() does, which needs a server driven into that state, and the bundled sqlite describer only fails for a column index past its own count, which the describe loop never passes it.