ext/pgsql: Removed pg_service(), unavailable with any released libpq - #23857
Open
KentarouTakeda wants to merge 1 commit into
Open
KentarouTakeda wants to merge 1 commit into
KentarouTakeda wants to merge 1 commit into
Conversation
KentarouTakeda
requested review from
devnexen and
kocsismate
as code owners
September 23, 2026 02:58
Member
|
Hi @KentarouTakeda good thinking ; what I would do however if I were you is to "reimplement" on master using the information from the connection itself instead wdyt ? |
Contributor
Author
|
@devnexen Still, restoring the function from 8.5 makes sense too, and it avoids dealing with the password. |
Member
|
@adoy @DanielEScherzer @edorian what do you think if we remove this for the next 8.5 release ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PQservice()never shipped in a released libpq; it was dropped during the PostgreSQL 18 beta.See also php/doc-en#5873