Repository navigation
feature_checks: add a removeextension check for multi-dot file names - #47
Merged
Merged
Conversation
Attaches annual.report.zip, archive.tar.gz and probe.zip to the first post and checks the download link text loses only the last extension. Fails on removeextension before #5 and passes after it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
feature_checks.pycheck forrmcgirr83/removeextension, the regression test for phpbbmodders/removeextension#5.The check attaches three files to the first post and reads the download link text:
annual.report.zipannual.reportarchive.tar.gzarchive.tarprobe.zipprobeIt removes the attachment rows and files afterwards, so the disable/purge/enable round trip runs on a clean board.
Claude ran it with
--seed-boardon a seed-forum phpBB 3.3.19 SQLite board with removeextension mounted:62493cf(with Release from the default branch and reject archived repositories #5): 9/9 checks passed, no PHP errors.tests/test-phpbb-test-board.shpasses locally.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code