Repository navigation
Add noknok org + PIDs 4E4E (USB module) and 4E42 (USB bootloader) - #1230
Conversation
|
Friendly ping — this has been open ~4 weeks with both checks passing. Happy to make any changes if something needs adjusting. Thanks for maintaining pid.codes! |
|
@TunalunaDE Please remove claude coauthorship from your project so pidcodes doesn't get blacklisted from people with that account blocked. You may need to close this PR and open a new one. There's also an ongoing discussion surrounding accepting PIDs for products that use a separate PID for their bootloader, instead of using a common bootloader PID. So I am going to leave this without recommendation until we get further clarification. Recommend not merging at this time, but it need to have the dual-code question settled, as well as maybe needing to be re-opened. ❌ / ❓ |
8e45aec to
649d76b
Compare
|
Thanks for the review! As requested, I have removed the Claude co-authorship. On the bootloader PID: I will not allocate one distinct PID per (future) product. I plan to use I'm using a distinct PID for the bootloader mainly for recovery robustness: a module with dead/corrupt app firmware still enumerates unambiguously as the bootloader, so it can always be re-flashed OTA without the host having to guess its state. I understand the fear of wasting PIDs just for a bootloader, but since I am planning to re-use the same PIDs for several products within the ecosystem, I hope this is acceptable for my case. |
|
In this case, I feel the distinct PID for bootloading is required. I know this isn't quite what @tannewt had mentioned in the past, but I don't see a way around it for this user. I am going to go ahead and approve. |
cnlohr
left a comment
There was a problem hiding this comment.
See discussion in thread about discussion surrounding dual PID usage.
|
Thank you for taking the time to review my PR and allocating the PIDs to my project. Really appreciate your review, and glad to be part of the pid.codes family now! 🎉 |
Adds the noknok organization page and two PIDs for the noknok open-source modular electronics ecosystem.
1209/4E4E1209/4E42🤖 Generated with Claude Code