Repository navigation
Assemble multiline SSE data before decoding chat chunks - #706
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both assistant chat endpoints parse each SSE
data:line as a complete JSON object. A valid event with JSON spread across multiple data fields raisesorjson.JSONDecodeErrorin both synchronous and asynchronous clients. This was reproduced with replayed HTTP responses, not observed against a hosted assistant.Solution
Share a small event-data assembler across the four parsers. Join data fields with newlines and decode only after an event boundary, ignoring non-data fields and comments. Preserve the existing final-event-at-EOF compatibility and
[DONE]handling. Completed events are yielded immediately without reading the next event.The event framing follows the SSE interpretation rules; the existing EOF compatibility is intentionally retained.
Type of Change
Test Plan