Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CensoredGaussianLogLikelihood.evaluateS1assumes the number of model parameters equals the number of outputs. For example, the two-output, four-parameterLotkaVolterraModelraises a broadcast error. With matching counts, parameters shared by outputs can instead receive incorrect gradients because the censored terms weight and sum the wrong axis.Broadcast the censoring masks over model parameters, apply each output's noise scale, and sum over outputs. Keep the likelihood values and model evaluations unchanged.
Add 24 numerical regression cases covering one/two outputs, one/two/three model parameters, shared parameters, unequal noise, and no/lower/upper/both censoring. Seventeen cases fail on unchanged main; all pass after on Python3.10/NumPy1.26 and Python3.12/NumPy2.5.
I also checked 24 continued gradient-descent fits using the recorded hare/lynx series supplied with
LotkaVolterraModel, constructed censoring variants, and ordinary Gaussian/diagonal controls. Twelve shape errors and three incorrect gradient trajectories become zero against an independent ODE solve and finite-difference reference; all nine previously working control trajectories stay identical.Validation: full unit suite passes (766 tests, three optional skips), Flake8 passes, and the clean HTML documentation build succeeds without warnings.
CHANGELOG.mdis updated.Related to #667.