Skip to content

Add --ignore-source-keyspace to move-tables complete and cancel - #1450

Merged
no-itsbackpack merged 1 commit into
mainfrom
egomez/move-tables-ignore-source-keyspace
Sep 29, 2026
Merged

no-itsbackpack merged 1 commit into
mainfrom
egomez/move-tables-ignore-source-keyspace

Conversation

@no-itsbackpack

Copy link
Copy Markdown
Contributor

pscale branch vtctl move-tables complete and cancel couldn't finish a workflow once its source keyspace had been deleted or become unreachable, which can happen when the source is an external keyspace on a MySQL server that's already been shut down. Vitess has an option for this, and the CLI now exposes it:

$ pscale branch vtctl move-tables complete mydb main \
    --workflow import_mydb --target-keyspace mydb \
    --keep-data=true --keep-routing-rules=false \
    --ignore-source-keyspace

With --ignore-source-keyspace, the workflow is completed or canceled without locking, checking, or cleaning up anything in the source keyspace. It's off by default and only sent when you pass it. The flag help and agent guide say to use it only when the source keyspace is gone. A complete --dry-run that includes the flag also includes it in the suggested next command.

🤖 Generated with Claude Code

Lets you finish or cancel a MoveTables workflow after its source keyspace
has been deleted or become unavailable.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@no-itsbackpack
no-itsbackpack marked this pull request as ready for review September 29, 2026 20:29
@no-itsbackpack
no-itsbackpack requested a review from a team as a code owner September 29, 2026 20:29

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Approved. Cursor Bugbot completed with no findings that need human review; Cursor Security Agent was not running. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: cli-reviewer

@no-itsbackpack
no-itsbackpack merged commit b9be1d0 into main Sep 29, 2026
5 checks passed
@no-itsbackpack
no-itsbackpack deleted the egomez/move-tables-ignore-source-keyspace branch September 29, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants