Repository navigation
Conversation
From 1.64, an action whose navigation ends in the redirect's 204 never settles.
This was referenced Oct 10, 2026
Racing it let a `goto()` to the same url start before the previous one settled, which fails with `net::ERR_ABORTED`.
From Playwright 1.63, navigating again to a URL whose request was left pending fails with `net::ERR_ABORTED`.
kbond
marked this pull request as draft
October 10, 2026 14:26
kbond
force-pushed
the
fix-route-handler-exceptions
branch
from
October 10, 2026 14:26
8644301 to
0913b0d
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a route handler throws, the exception unwinds out of the command in flight (a
goto()or click) while its request stays pending in the browser. From Playwright 1.63, navigating to the same URL again then fails withnet::ERR_ABORTED(see zenstruck/browser#215).The route is now aborted unless the handler already handled it, using
abortedso the navigation is cancelled without committing an error page. The client keeps waiting for the command in flight before throwing the handler's exception, so the browser is settled by the time the caller sees it.Depends on #186. Its commits show here until it's merged, and I'll rebase after.