Conversation
A marker.color array of color strings skipped the colorscale path. lineGroupStyle then left the stroke unset, so every arrow drew black. Co-authored-by: Bennett Payoyo <Yahiro025@users.noreply.github.com>
The entry uses a placeholder number until the upstream pull request exists. Rename draftlogs/XXXX_fix.md to that pull request number. Co-authored-by: Bennett Payoyo <Yahiro025@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8026.
A discrete
marker.colorarray on a quiver trace left every arrow black. Array colors made the stroke argumentundefined, and an unset stroke draws black. Numeric arrays still go through the colorscale later; a list of color strings does not turn the colorscale on, so every arrow stayedrgb(0, 0, 0).strokeArrowColorsinsrc/traces/quiver/style.jsstill sends numeric arrays through the colorscale. For any other array it sets each valid color string on that arrow.src/traces/quiver/plot.jsuses the same helper so the first draw and a later restyle stay in sync.Draftlog
Placeholder
draftlogs/XXXX_fix.mdwill be renamed to match this PR number after open.Test plan
quiversuite: new discretemarker.colorregression + existing coverage (18/18)Notes
Assisted by AI tooling; reviewed before opening. Authorship Yahiro025-only.