Skip to content

Standardize modal and panel close controls #183

Closed

Description

@prabothcharith

Audit every modal, drawer, panel, and expanded view in the plugin and provide a consistent close affordance. Close controls must be visible, keyboard accessible, correctly labelled, positioned within the component, and restore focus to the opener. Escape behavior, outside-click behavior, scroll locking, and nested/long-content panels must be intentional and tested.

Acceptance criteria:

  • Every dismissible overlay has a clear close button or equivalent accessible control.
  • Close buttons remain visible and usable at narrow widths and high zoom.
  • Focus management and Escape handling are consistent across all overlays.
  • No overlay leaves the page stuck, clipped, or unable to scroll.

Activity

  1. prabothcharith commented on Nov 16, 2026

    @prabothcharith
    OwnerAuthor

    Screenshot references

    These views show the modal/panel close and overflow concerns to include in the close-control audit:

    Translation panel
    Dictionary dialog

  2. prabothcharith commented on Nov 16, 2026

    @prabothcharith
    OwnerAuthor

    Completed in PR #198 (commit 872a5cf, docs/tests 0234149): standardized shared ModalDialog and panel close affordances, Escape handling, scroll behavior, and focus restoration across all overlays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions