APS: New Adapter - #4638
Open
sreddyba-amzn wants to merge 1 commit into
Open
APS: New Adapter#4638sreddyba-amzn wants to merge 1 commit into
sreddyba-amzn wants to merge 1 commit into
Conversation
3 tasks done
osulzhenko
requested review from
CTMBNara,
Fuska1,
bukrain and
gmiedlar-ox
and removed request for
CTMBNara
September 22, 2026 08:57
CTMBNara
requested changes
Sep 28, 2026
sreddyba-amzn
force-pushed
the
aps/v1.0.0
branch
3 times, most recently
from
September 29, 2026 19:26
cf27a2a to
b798fb9
Compare
CTMBNara
requested changes
Sep 30, 2026
sreddyba-amzn
force-pushed
the
aps/v1.0.0
branch
from
September 30, 2026 18:42
b798fb9 to
0a6992a
Compare
gmiedlar-ox
reviewed
Oct 1, 2026
sreddyba-amzn
force-pushed
the
aps/v1.0.0
branch
from
October 1, 2026 19:01
0a6992a to
3353a84
Compare
gmiedlar-ox
approved these changes
Oct 2, 2026
CTMBNara
requested changes
Oct 2, 2026
Comment on lines
+124
to
+127
| if (imp.getExt() == null) { | ||
| throw new PreBidException( | ||
| "imp %s: missing APS bidder params".formatted(imp.getId())); | ||
| } |
Author
There was a problem hiding this comment.
Done — removed the imp.ext == null guard and its test; agreed core guarantees imp.ext is non-null for a selected bidder. Kept the convertValue try/catch to surface malformed params as bad_input. Pushed in the latest revision, thanks!
**Overview:** APS (Amazon Publisher Services) bid adapter initial open source release. **Changes:** - (feat) Banner ad support - (feat) Video ad support - (feat) Multi format ad support - (docs) Integration guide
sreddyba-amzn
force-pushed
the
aps/v1.0.0
branch
from
October 2, 2026 20:46
3353a84 to
540abc3
Compare
CTMBNara
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
APS (Amazon Publisher Services) bid adapter initial open source release.
🧠 Rationale behind the change
APS (Amazon Publisher Services) bid adapter initial open source release.
🔎 New Bid Adapter Checklist
🧪 Test plan
Validated with Integration tests.
🏎 Quality check