Skip to content

Fix package manager asset URLs #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sh1pt-actions-fleet merged 1 commit into from
Nov 1, 2026
Merged

Fix package manager asset URLs #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/lib/package-managers/chocolatey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ export class ChocolateyPackageManager extends BasePackageManager {

const downloadUrl =
exe?.downloadUrl ??
`https://github.com/profullstack/pairux.com/releases/download/v${release.version}/PairUX-${release.version}-x64.exe`;
`https://github.com/profullstack/pairux.com/releases/download/v${release.version}/PairUX.Setup.${release.version}.exe`;

// Get checksum from asset or from checksums map (required for Chocolatey validation - CPMR0073)
// Note: checksums file may have spaces in filename (e.g., "PairUX Setup 0.1.17.exe")
// while GitHub asset has dots (e.g., "PairUX.Setup.0.1.17.exe")
const checksum =
exe?.sha256 ??
release.checksums.get(`PairUX Setup ${release.version}.exe`) ??
release.checksums.get(`PairUX-${release.version}-x64.exe`) ??
release.checksums.get(`PairUX.Setup.${release.version}.exe`) ??
'';

if (!checksum) {
Expand Down
4 changes: 2 additions & 2 deletions scripts/lib/package-managers/homebrew.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class HomebrewPackageManager extends BasePackageManager {
}

generateManifest(release: ReleaseInfo): Promise<string> {
// Find the DMG assets for arm64 and x64
// Find the DMG assets for Apple Silicon and Intel
const arm64Dmg = this.findAsset(
release,
(a) => a.name.includes('arm64') && a.name.endsWith('.dmg')
Expand All @@ -69,7 +69,7 @@ export class HomebrewPackageManager extends BasePackageManager {

on_intel do
sha256 "${x64Sha}"
url "https://github.com/profullstack/pairux.com/releases/download/v#{version}/PairUX-#{version}-x64.dmg",
url "https://github.com/profullstack/pairux.com/releases/download/v#{version}/PairUX-#{version}.dmg",
verified: "github.com/profullstack/pairux.com/"
end

Expand Down
14 changes: 7 additions & 7 deletions scripts/lib/package-managers/package-managers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ function createSampleRelease(version = '1.0.0'): ReleaseInfo {
tagName: `v${version}`,
assets: [
{
name: `PairUX-${version}-x64.exe`,
downloadUrl: `https://github.com/profullstack/pairux.com/releases/download/v${version}/PairUX-${version}-x64.exe`,
name: `PairUX.Setup.${version}.exe`,
downloadUrl: `https://github.com/profullstack/pairux.com/releases/download/v${version}/PairUX.Setup.${version}.exe`,
size: 100000000,
contentType: 'application/octet-stream',
sha256: 'ABC123DEF456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789A',
Expand All @@ -50,8 +50,8 @@ function createSampleRelease(version = '1.0.0'): ReleaseInfo {
sha256: 'DEF456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF01',
},
{
name: `PairUX-${version}-x64.dmg`,
downloadUrl: `https://github.com/profullstack/pairux.com/releases/download/v${version}/PairUX-${version}-x64.dmg`,
name: `PairUX-${version}.dmg`,
downloadUrl: `https://github.com/profullstack/pairux.com/releases/download/v${version}/PairUX-${version}.dmg`,
size: 115000000,
contentType: 'application/octet-stream',
sha256: 'GHI789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF012345',
Expand All @@ -66,15 +66,15 @@ function createSampleRelease(version = '1.0.0'): ReleaseInfo {
],
checksums: new Map([
[
`PairUX-${version}-x64.exe`,
`PairUX.Setup.${version}.exe`,
'ABC123DEF456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789A',
],
[
`PairUX-${version}-arm64.dmg`,
'DEF456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF01',
],
[
`PairUX-${version}-x64.dmg`,
`PairUX-${version}.dmg`,
'GHI789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF012345',
],
[
Expand Down Expand Up @@ -135,7 +135,7 @@ describe('WingetPackageManager', () => {
const manifests = await winget.generateManifest(release);

expect(manifests.installer).toContain(
'InstallerUrl: https://github.com/profullstack/pairux.com/releases/download/v2.0.0/PairUX-2.0.0-x64.exe'
'InstallerUrl: https://github.com/profullstack/pairux.com/releases/download/v2.0.0/PairUX.Setup.2.0.0.exe'
);
});

Expand Down
6 changes: 3 additions & 3 deletions scripts/lib/package-managers/scoop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class ScoopPackageManager extends BasePackageManager {
// Find the Windows installer (NSIS exe)
const x64Exe = this.findAsset(
release,
(a) => a.name.endsWith('.exe') && a.name.includes('x64')
(a) => a.name.startsWith('PairUX.Setup.') && a.name.endsWith('.exe')
);

// If no x64 specific, find any exe
Expand All @@ -65,7 +65,7 @@ export class ScoopPackageManager extends BasePackageManager {
license: 'MIT',
url:
exe?.downloadUrl ??
`https://github.com/profullstack/pairux.com/releases/download/v${release.version}/PairUX-${release.version}-x64.exe`,
`https://github.com/profullstack/pairux.com/releases/download/v${release.version}/PairUX.Setup.${release.version}.exe`,
hash: exe?.sha256 ?? 'SHA256_PLACEHOLDER',
installer: {
args: ['/S', '/D=$dir'],
Expand All @@ -79,7 +79,7 @@ export class ScoopPackageManager extends BasePackageManager {
github: 'https://github.com/profullstack/pairux.com',
},
autoupdate: {
url: `https://github.com/profullstack/pairux.com/releases/download/v$version/PairUX-$version-x64.exe`,
url: `https://github.com/profullstack/pairux.com/releases/download/v$version/PairUX.Setup.$version.exe`,
},
};

Expand Down
2 changes: 1 addition & 1 deletion scripts/lib/package-managers/winget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class WingetPackageManager extends BasePackageManager {
const x64Sha = x64Exe?.sha256?.toUpperCase() ?? 'SHA256_PLACEHOLDER';
const downloadUrl =
x64Exe?.downloadUrl ??
`https://github.com/profullstack/pairux.com/releases/download/v${release.version}/PairUX-${release.version}-x64.exe`;
`https://github.com/profullstack/pairux.com/releases/download/v${release.version}/PairUX.Setup.${release.version}.exe`;

// Version manifest
const versionManifest = `# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.10.0.schema.json
Expand Down
Loading