Repository navigation
Conversation
run-tests accepted any unknown option and forwarded it to the Python test runner as an extra test parameter, so a typo such as --prompt_timeout (instead of --prompt-timeout) only failed inside the SDK container, with the error visible only in the backend logs. Parse options before a literal -- strictly, so unknown options fail with "No such option" and a suggestion. Arguments after -- are still forwarded as test parameters. Closes #1215
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Tick the box to add this pull request to the merge queue (same as
|
Suite updates carry an errors list (e.g. a failed suite setup), but the CLI only printed the suite title and state, so the reason was visible only in the backend log. Print each suite error once. Related to #1215
greens
approved these changes
Nov 18, 2026
Everything after -- is passed to the test runner, so an option of run-tests itself there (e.g. -- --prompt-timeout 5, or the --prompt_timeout typo) was either rejected by the runner deep inside the run or silently ignored. Fail up front and tell the user to pass it before the separator. The option names come from the command definition, so they cannot drift. Related to #1215
greens
reviewed
Nov 19, 2026
A long error glued to the header with ' - ' is hard to read. Put multi-line API error content below the header, and indent every line of a multi-line suite error. Related to #1215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
th-cli run-testssilently accepted any unknown option and forwarded it to the Python test runner as an extra test parameter. A typo such as--prompt_timeout(instead of--prompt-timeout) only failed inside the SDK container, and the error was visible only in the backend logs.Closes #1215
Changes
run-testsnow splits its arguments at a literal--. Options before it are parsed strictly, so unknown options fail with exit code 2, for exampleNo such option '--prompt_timeout'. Did you mean '--prompt-timeout'?--are still forwarded unchanged as test parameters (-- --int-arg PIXIT.X:1).--are now errors instead of being ignored.ignore_unknown_optionsandallow_extra_argsfrom the command's context settings.Behaviour change
Passing test parameters without
--(e.g.run-tests -t X --int-arg PIXIT.X:1) now errors. The help text and docs describe only the--form.Tests
Added three tests in
tests/test_run_tests.py: unknown option rejected with suggestion, stray positional argument rejected, and args after--still forwarded. Five other tests in that file (config-file related) fail identically on the unchanged branch.Not covered here: surfacing SDK startup errors in the CLI output (needs a backend change).