Repository navigation
Fix your own sent messages sometimes showing twice in a room - #1376
Merged
Merged
Conversation
Update our matrix-sdk fork to pick up three upstream fixes for bugs that could put a timeline's internal list of the room's events out of step with the event cache's list. When you send a message, the SDK's send queue puts a copy of it into the event cache as soon as the server accepts it. When sync then delivers the real event, the event cache replaces that copy and tells the timeline to remove it by its index. If the timeline's list had drifted, that removal hit a different event, so your message stayed twice and the event before it could disappear from the timeline. The fixes: * Building a timeline could add an event twice if it reached the event cache while the timeline was being built. Robrix builds a room's timeline as soon as the room appears, e.g., right after joining it, which is when that room's events are still arriving. * Clearing a timeline while one of your messages was still being sent kept the events that have no item of their own, like reactions. * An event with no type made the event cache remove the wrong event when replacing a duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported that in a private room, every message they sent showed up twice for them, while the other side saw it once and the log showed only one send.
This was a Matrix SDK bug that's already been fixed upstream, now we cherry pick those 3 fixes and point Robrix at that fixed sdk.