Repository navigation
Conversation
herin049
force-pushed
the
perf/remove-dyn-writer
branch
from
November 6, 2026 19:58
8b93088 to
9ff12dd
Compare
Signed-off-by: Lukas Hering <lukasheringb@gmail.com>
Signed-off-by: Lukas Hering <lukasheringb@gmail.com>
herin049
force-pushed
the
perf/remove-dyn-writer
branch
from
November 6, 2026 19:59
9ff12dd to
735f9a7
Compare
herin049
marked this pull request as ready for review
November 6, 2026 20:36
Signed-off-by: Lukas Hering <lukasheringb@gmail.com>
Signed-off-by: Lukas Hering <lukasheringb@gmail.com>
krisztianfekete
left a comment
Member
There was a problem hiding this comment.
Nice, thanks, LGTM with the inline fix. Please also add CHANGELOG entries for the output changes.
krisztianfekete
left a comment
Member
There was a problem hiding this comment.
Thanks, please sign the DCO so we can merge this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The text encoders write every small fragment (
"{",",","=\"", numbers, …) through&mut dyn Write. These small writes introduce measurable overhead due to dynamic dispatch.This PR adds a new
TextBuftype to buffer writes to the underlying writer to ensure hot path writes are statically dispatched.Benchmarks (Apple M5 Pro - 48GB memory, rustc 1.94.1)
cargo bench --bench text, compared with--baselineagainstmaster:OpenMetrics (
encoding::text)masterencodeencode_realistic_string_labelsencode_escaped_label_valuesPrometheus text (
encoding::prometheus_text)masterprometheus_text_encodeprometheus_text_encode_realistic_string_labelsprometheus_text_encode_escaped_label_valuesBuffer sizes from 1 to 64 KiB all landed within about 3% of each other. 4 KiB was chosen to keep the footprint small.