Repository navigation
Conversation
Even though a negative count may arise from arithmetic operations from on native histograms, we don't believe that the resulting distribution means anything or is useful. Instead of changing the validation of histograms stored in Prometheus , we're making the specification more strict. Note: negative histograms may still be calculated in Prometheus and returned as PromQL query results or used as intermediate values in calculations. As explained by the native histograms specification: https://prometheus.io/docs/specs/native_histograms/#unary-minus-and-negative-histograms Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/om2-no-negative-buckets
branch
from
October 16, 2026 07:02
b9e7740 to
f2d28c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though a negative count may arise from arithmetic operations from on native histograms, we don't believe that the resulting distribution means anything or is useful. Instead of changing the validation of histograms stored in Prometheus , we're making the specification more strict.
Note: negative histograms may still be calculated in Prometheus and returned as PromQL query results or used as intermediate values in calculations. As explained by the native histograms specification: https://prometheus.io/docs/specs/native_histograms/#unary-minus-and-negative-histograms