Repository navigation
rapl: fix enable-zone-label flag help text - #3855
Open
manunicholasjacob wants to merge 1 commit into
Open
manunicholasjacob wants to merge 1 commit into
manunicholasjacob wants to merge 1 commit into
Conversation
The help text of --collector.rapl.enable-zone-label was copied from the systemd collector's --collector.systemd.enable-start-time-metrics flag. Describe what the flag actually does: expose node_rapl_joules_total with a rapl_zone label instead of one metric per zone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manu Nicholas Jacob <manunicholasjacob@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SuperQ The help text of
--collector.rapl.enable-zone-labelwas copied from the systemd collector ("Enables service unit metric unit_start_time_seconds"), so--helpmisdescribes the flag. This changes it to describe what the flag does: a singlenode_rapl_joules_totalmetric with arapl_zonelabel instead of one metric per zone.How tested:
gofmt -l collector/clean,go vet ./collector/...clean,make testpasses (go1.26.0, WSL2). Built the binary and checked--help, and scraped the rapl collector againstcollector/fixtures/syswith and without the flag to confirm the new text matches the output (node_rapl_core_joules_total/node_rapl_package_joules_totalwithout it,node_rapl_joules_total{rapl_zone="core|package"}with it).AI disclosure: I used Claude Code to help prepare this change; I reviewed the diff and the test output.