Repository navigation
Fix memory allocation for gsFont path strings - #107
Open
PS2HomeDeveloper wants to merge 1 commit into
Open
PS2HomeDeveloper wants to merge 1 commit into
PS2HomeDeveloper wants to merge 1 commit into
Conversation
Allocate additional space for null terminator in gsFont paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gsKit_init_fontallocatesPathandPath_DATusingstrlen(path), but copies the strings withstrcpy, which also writes the terminating NUL byte. Both allocations are therefore one byte too small.Allocate space for the terminator in both font-path buffers.
Testing
.datpath is formed correctly.