Repository navigation
fix(erl): match erl_id to the library name the build produces - #939
Merged
Merged
Conversation
Six erl-support.c files declared an erl_id that differs from the .erl the buildsystem emits (tcpip, tcpips, keyboard, ps2snd, remote, sbv). The buildsystem name is the intended one (ps2dev#924).
fjtrujy
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect 4 from #924. Six
erl-support.cfiles declare anerl_idthat differs from the.erlthe buildsystem emits (EE_LIB, orlib<dir>fromRules.lib.make): tcpiplibps2ip141->libps2ip, tcpipslibps2ip->libps2ips, keyboardlibkeyboard->libkbd, ps2sndlibps2kit->libps2snd, remotelibremote->librm, sbvlibsbv->libpatches. Per your reply on #924 the buildsystem name wins, so only theerl-support.cside changes. Noerl_dependanciesentry names any of the old ids. The other 30 already match.