Repository navigation
fix(ci): make MC/DC, WIT round-trip and claim-check gates fail on bad input - #240
Merged
Merged
Conversation
… input
- mcdc-gate.sh: reject a missing or non-integer overall.* field before
the floor comparisons; `[ null -lt 155 ]` errored, `if` read it as
false, and the gate printed PASSED.
- ci.yml: drop `| head -50 || true` from the scry.wit check so a parse
or resolve error fails the step; scry.wit resolves standalone.
- claim-check.py: exit 2 when no claims are declared, and fail a claim
that has no evidence predicates.
Planted inputs, old -> new exit: report `{}` 0 -> 1; conditions_proved
"abc" 0 -> 1; `claims: []` 0 -> 2; claim without evidence 0 -> 1.
Valid report (160 proved) and the real claims.yaml stay 0.
Fixes #239
Refs: FEAT-102
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KEjmjcVaTucsMZy5Fubas7
clippy 1.100.0 (rustc 2026-11-09) adds needless_range_loop at crates/scry-pentagon/src/lib.rs:570 and fails the Clippy job under -D warnings. Behaviour is unchanged: lt has n*n = 9 entries and take(9) keeps the bound explicit. All five CI clippy invocations exit 0 under 1.100.0; scry-sai-pentagon tests 17/17 pass. Trace: skip Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjcVaTucsMZy5Fubas7
avrabe
force-pushed
the
fix/gate-potency-mcdc-wit-claims
branch
from
November 13, 2026 20:37
9b36de0 to
a0abe15
Compare
📐 rivet artifact deltaPR: #240 Base SHA: Validationhead — `rivet validate` resultbase — `rivet validate` result (for comparison)Artifact stats
full stats — headDiff (base → head)AADL model — headPosted by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239: three required checks reported success on input that should fail them.
mcdc-gate.shrejects missing or non-integeroverall.*before the floor tests{}: 0 → 1;conditions_proved: "abc": 0 → 1| head -50 || true; scry.wit resolves standaloneclaims: []: 0 → 2; claim without evidence: 0 → 1Valid inputs stay green: a report with 160 proved / 4 full exits 0, the real
claims.yamlgives 7/7 and exit 0, and the unmodified scry.wit parses with exit 0 under wasm-tools 1.245.1.The gate tests ran the extracted gate section of
mcdc-gate.shlocally (fromPROVED=toPASSED), not the full witness pipeline. CI runs the full path.Two further commits came out of the first CI run:
Refs: FEAT-102on the gate commit, plusartifacts/roadmap-v3.4-gate-planted-input.yaml(FEAT-102, traces to REQ-005). Commit traceability had failed with orphans=1. Locally,rivet validatepasses with no FEAT-102 warnings and the trailer guard passes.crates/scry-pentagon/src/lib.rs:570: clippy 1.100.0 (2026-11-09) addedneedless_range_loopthere. main last went green on 2026-11-08 with an older stable, so main would also go red on its next run. All five CI clippy invocations exit 0 under 1.100.0, and scry-sai-pentagon passes 17/17 tests. Pin the toolchain through varve: covalent realm, rolling 2026.11.10 #238 (varve toolchain pin) addresses the drift itself.🤖 Generated with Claude Code
https://claude.ai/code/session_01KEjmjcVaTucsMZy5Fubas7