Skip to content

chore: move to .NET 11 and fix reported extraction issues - #17

Merged
drpetersonfernandes merged 2 commits into
masterfrom
chore/net11-and-reported-fixes
Nov 13, 2026
Merged

drpetersonfernandes merged 2 commits into
masterfrom
chore/net11-and-reported-fixes

Conversation

@drpetersonfernandes

Copy link
Copy Markdown
Collaborator

What

  • Move the app and tests to net11.0 / net11.0-windows, build the five libraries for net11.0 too, bump Avalonia to 12.1.6, SharpCompress to 0.50.9 and the analyzers to 3.0.339, and update CI, the release workflow, docs and version tables.
  • Fix the reported extraction and tool-discovery issues.

Fixes

  • #69847 - Unix 7zz permission denied: repair missing execute bits on bundled tools at startup, fall back to PATH when they cannot be repaired, and report the tool path plus the chmod +x remedy when it still cannot start.
  • #69841 / #69842 / #69843 - access denied creating _extract_temp_*: extraction now names the output folder, the reason and the remedy instead of dumping CHD header fields and saying the file may be corrupt. The condition is excluded from bug reports.
  • #69844 - an MDSSharp assembly load failure no longer aborts the batch in the source-size pre-flight; the input is counted and the batch continues, with the real conversion path reporting any genuine MDS problem.

Verification

  • dotnet build CSharp_CHDStudio.sln -c Release - 0 warnings, 0 errors
  • dotnet test CHDStudio.Tests/CHDStudio.Tests.csproj -c Release - 1304 passed
  • jb inspectcode --output=InspectCode.log CSharp_CHDStudio.sln - 0 warnings/errors (notes only)
  • New regression tests for the execute-bit repair, an unstartable tool, the extraction-folder message and its bug-report exclusion.

Not addressed here: #69728 (already fixed in 3.13.x), #69739 (needs the reported PBP file), and the BatchConvertToCHD reports (legacy app/repo).

Retarget the app and tests to net11.0/net11.0-windows, build the five libraries for net11.0 as well, bump Avalonia to 12.1.6, SharpCompress to 0.50.9 and the analyzers to 3.0.339, and update the CI, release, docs and version tables to match.
- Repair a missing Unix execute bit on bundled tools before starting them, fall
  back to PATH when the file cannot be made executable, and report the tool path
  plus the chmod remedy when it still cannot start (#69847).
- Treat an unwritable extraction destination as a folder/permission problem: name
  the folder and the remedy, keep CHD header diagnostics out of the message, and
  do not file a bug report for it (#69841, #69842, #69843).
- Keep the source-size pre-flight alive when the MDSSharp assembly cannot be
  loaded, so a non-MDS batch still starts and the conversion path reports the
  real problem (#69844).
- Add regression tests for the execute-bit repair, an unstartable tool, the new
  folder message and its bug-report exclusion.
Comment on lines +1330 to +1333
var fakeTool = Path.Combine(
_tempDir,
OperatingSystem.IsWindows() ? "fake7za.exe" : "fake7za"
);
);
File.WriteAllText(fakeTool, "not an executable");
var service = new ArchiveService(fakeTool, true);
var corruptPath = Path.Combine(_tempDir, "corrupt-unstartable.7z");
var service = new ArchiveService(fakeTool, true);
var corruptPath = Path.Combine(_tempDir, "corrupt-unstartable.7z");
File.WriteAllText(corruptPath, "not a 7z archive");
var tempDir = Path.Combine(_tempDir, "extract");
{
// Discovery uses the result to skip to the next candidate instead of returning a path that
// Process.Start cannot run.
var missing = Path.Combine(Path.GetTempPath(), $"missing_tool_{Guid.NewGuid():N}");
{
// Some archive managers extract the release zip without Unix modes, which leaves the
// bundled 7zz at 0644 and makes Process.Start fail with "Permission denied".
var tool = Path.Combine(Path.GetTempPath(), $"tool_{Guid.NewGuid():N}");
[Fact]
public void OutputDirectoryUnavailableExceptionNamesTheFolderAndReason()
{
var directory = Path.Combine(Path.GetTempPath(), "protected-output");
Comment on lines +1330 to +1333
var fakeTool = Path.Combine(
_tempDir,
OperatingSystem.IsWindows() ? "fake7za.exe" : "fake7za"
);
);
File.WriteAllText(fakeTool, "not an executable");
var service = new ArchiveService(fakeTool, true);
var corruptPath = Path.Combine(_tempDir, "corrupt-unstartable.7z");
var service = new ArchiveService(fakeTool, true);
var corruptPath = Path.Combine(_tempDir, "corrupt-unstartable.7z");
File.WriteAllText(corruptPath, "not a 7z archive");
var tempDir = Path.Combine(_tempDir, "extract");
{
// Discovery uses the result to skip to the next candidate instead of returning a path that
// Process.Start cannot run.
var missing = Path.Combine(Path.GetTempPath(), $"missing_tool_{Guid.NewGuid():N}");
{
// Some archive managers extract the release zip without Unix modes, which leaves the
// bundled 7zz at 0644 and makes Process.Start fail with "Permission denied".
var tool = Path.Combine(Path.GetTempPath(), $"tool_{Guid.NewGuid():N}");
[Fact]
public void OutputDirectoryUnavailableExceptionNamesTheFolderAndReason()
{
var directory = Path.Combine(Path.GetTempPath(), "protected-output");
@drpetersonfernandes
drpetersonfernandes merged commit c93f68c into master Nov 13, 2026
12 checks passed
@drpetersonfernandes
drpetersonfernandes deleted the chore/net11-and-reported-fixes branch November 13, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants