Repository navigation
Correct values docstrings of write_coils and readwrite_registers - #3065
Merged
janiversen merged 1 commit intoOct 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3039, as suggested there: the
valuesdocstrings ofwrite_coilsandreadwrite_registerssaid a single value can be passed, but both take a sequence. Ondev,write_coils(0, True)raisesTypeError: object of type 'bool' has no len(), andreadwrite_registers(values=5)does the same forint. This drops the wrong part, so both now read likewrite_registers.ruff check,ruff format --checkandcodespellonpymodbus/client/mixin.pyare clean.AI disclosure: written with help from AI coding tools (Claude Code); I reviewed the change and checked the behaviour above before submitting.