Skip to content

ci: move the greenlight AI review caller to greenlight-actions v2 - #139

Merged
pyth-ops merged 1 commit into
mainfrom
greenlight-review-v2-pyth-examples
Oct 20, 2026
Merged

pyth-ops merged 1 commit into
mainfrom
greenlight-review-v2-pyth-examples

Conversation

@jayantk

@jayantk jayantk commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

What changes

This PR replaces .github/workflows/greenlight-review.yml with the v2 caller from dourolabs/greenlight-actions/examples/greenlight-review.yml. The file is copied unchanged. Compared with the current v1 caller, it:

  • calls greenlight-review-impl.yml@v2 instead of @v1;
  • adds id-token: write to the review job's permissions;
  • declares an optional verdict_url input under workflow_dispatch and passes it to the reusable workflow;
  • updates the header comments.

The review job in the reusable workflow keeps contents: read. Only its report job requests id-token: write.

Why

Greenlight will soon accept an AI review verdict only from the workflow run that it dispatched. In v2, the report job posts the check run as before. It then sends the verdict to Greenlight's verdict_url with a GitHub OIDC token, so Greenlight can confirm which run sent it.

Once Greenlight ships that change, it sends verdict_url with every dispatch. A v1 caller does not declare that input, so GitHub rejects the dispatch with 422, and Greenlight shows review_dispatch_failed on the PR.

What changes for you today

Nothing. This repo does not configure any Greenlight reviews, so Greenlight does not dispatch this workflow today. Even if it did, the current Greenlight server sends only the six existing inputs. verdict_url stays empty, and the report job then does exactly what v1 does.

This PR means that if the repo adds a Greenlight review later, it already runs the right caller version.

Checks

  • The new file is byte-identical to examples/greenlight-review.yml at the v2 tag of dourolabs/greenlight-actions.
  • scripts/check-review-workflow.sh in dourolabs/greenlight-actions passes against that example.
  • The YAML parses, and prettier --check passes on it.

Because this PR edits .github/workflows/**, a maintainer of this repo needs to merge it.

🤖 Generated with Claude Code

Replace .github/workflows/greenlight-review.yml with the v2 example from
dourolabs/greenlight-actions. The caller now calls the impl at @v2,
grants id-token: write, and passes the optional verdict_url input.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pyth-ops
pyth-ops merged commit 35b96f7 into main Oct 20, 2026
6 of 7 checks passed
@pyth-ops
pyth-ops deleted the greenlight-review-v2-pyth-examples branch October 20, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants