Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When every unit above microseconds is suppressed,
precisedelta()can round the microsecond count even though the input is an exacttimedelta. This occurs for durations around 285 years or longer, where the count reaches the integer precision limit of a float:Changes proposed in this pull request:
2**53, including negative timedeltas under the existing absolute-duration behavior.Validation on Windows with Python 3.12.10: the new cases produced 4 failures and 2 passing controls before the fix. Afterward, all 398 time tests and the full suite with source doctests pass (897 passed, 2 skipped). The skipped tests require GNU gettext tools; all 36 existing translation catalogs were compiled locally with polib. Project-pinned Ruff 0.16.10 and Black 26.10.0 pass on the changed files, mypy 2.4.0 passes all 14 files, and
git diff --checkpasses.Prepared and tested with OpenAI Codex assistance.