Repository navigation
Use "sonra" for future times in Turkish - #501
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 12 12
Lines 1020 1024 +4
=======================================
+ Hits 1017 1021 +4
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hugovk
enabled auto-merge (squash)
November 2, 2026 20:48
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Turkish translation of "%s from now" is "şu andan itibaren %s", so naturaltime returns "şu andan itibaren 3 gün" for a date three days ahead. This reads as "for 3 days starting now" and describes a period rather than a point in time. The usual phrasing is "3 gün sonra", which also matches "%s önce" for past times.
I added Turkish checks to test_i18n for both directions. The future check fails with the old catalog. After generating the .mo files, the full test suite passes.