Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #258.
get_type_hints()currently tries to resolve annotations for parameters explicitly excluded with@noninjectable. An unresolved forward reference or a recursive alias from another module can therefore prevent a call even when the caller supplies that argument.I filter those parameter names through the existing annotation proxy before type-hint evaluation, in both binding inference and initial
Inject[...]discovery. Injected parameters still resolve normally and keep their existing errors. The regressions cover both decorator orders, constructors, stacked keyword-only exclusions, explicit discovery and missing required arguments.Validation:
git diff --checkpassed.The change is limited to names declared with
@noninjectable; general recursive-alias resolution andNoInjectannotations retain their current behavior. Python 3.14 and PyPy were not run locally.