Repository navigation
Conversation
Author
|
update ? |
Collaborator
|
Thank you for the contribution! Parts of this are now on master via #461 (253-character limit) and #485 (underscore in the last label). The rest rewrites the TLD rules, which is a larger behaviour change than we want to take in one step. If you'd like to pursue that, please open an issue or a small PR against current master with ruff-clean code and tests. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a domain validation bypass where invalid TLDs containing _ or -, and domains longer than the DNS maximum length, were accepted by domain() and indirectly by hostname().