Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
r_ve=Falsecurrently enables raising because the decorator checks whether the keyword is present, rather than its value. This contradicts the documented switch and breaks callers that pass a boolean variable to choose between returned and raised validation errors.Use the flag value while retaining the environment override. Tests exercise both a validator that returns false (
slug) and one that raises while parsing (uuid), and verify that explicit true andRAISE_VALIDATION_ERROR=Truecontinue to raise. Before the change, the two false-flag regressions fail. Afterwards the full suite passes: 1,177 tests and doctests, with complete Ruff lint/format, strict Pyright and Bandit checks also passing.