Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fi_ssn("310299-010F")accepts a nonexistent 31 February when the control character is correct. The same issue accepts 29 February 1800/1900.Validate the complete birth date using the century marker before checking the serial and control character. This covers the additional century markers introduced in 2023, following the Finnish Tax Administration specification.
Tests: six invalid-date cases fail before the fix; four valid leap-year controls continue to pass. Full Tox lint, strict Pyright and Python 3.11–3.14 checks pass, with 1,181 tests per version. Ruff formatting and diff checks pass.
AI-assisted with GPT-6.1 Sol through Codex.