Skip to content

Clean up publish sequence number handling and tests - #2172

Merged
acogoluegnes merged 1 commit into
mainfrom
clean-up-publish-sequence
Nov 10, 2026
Merged

acogoluegnes merged 1 commit into
mainfrom
clean-up-publish-sequence

Conversation

@acogoluegnes

Copy link
Copy Markdown
Contributor

Replace the array holder used to pass the delivery tag to the metrics collector with a small private class that takes the publish sequence number once the message is encoded.

Run the AMQCommand encoding hook for commands without content too, so it is never silently skipped.

Check the next publish sequence number at the start and at the end of the sequence number tests, and test that headers larger than frame_max do not use a sequence number.

References #2171

Replace the array holder used to pass the delivery tag to the metrics
collector with a small private class that takes the publish sequence
number once the message is encoded.

Run the AMQCommand encoding hook for commands without content too, so
it is never silently skipped.

Check the next publish sequence number at the start and at the end of
the sequence number tests, and test that headers larger than frame_max
do not use a sequence number.

References #2171
@acogoluegnes
acogoluegnes marked this pull request as ready for review November 10, 2026 16:33
@acogoluegnes
acogoluegnes merged commit 6daa5ce into main Nov 10, 2026
7 checks passed
@acogoluegnes
acogoluegnes deleted the clean-up-publish-sequence branch November 10, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant