Repository navigation
Enable hostname verification by default with SSLSocketFactory - #2185
Merged
Merged
Conversation
ConnectionFactory#setSocketFactory now enables server hostname verification when it receives an SSLSocketFactory, like useSslProtocol and setSslContextFactory already do for blocking IO. Hostname verification is now a flag applied when the frame handler factory is created, instead of being added to the socket configurator each time it is enabled. Enabling it several times no longer stacks configurators, and setSocketConfigurator no longer removes it. useTlsWithNoVerification still disables it.
Contributor
Author
|
People needing to disable hostname verification (not recommended, because not safe) can use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionFactory#setSocketFactory now enables server hostname verification when it receives an SSLSocketFactory, like useSslProtocol and setSslContextFactory already do for blocking IO.
Hostname verification is now a flag applied when the frame handler factory is created, instead of being added to the socket configurator each time it is enabled. Enabling it several times no longer stacks configurators, and setSocketConfigurator no longer removes it. useTlsWithNoVerification still disables it.