Repository navigation
feat(panos): configure HA configuration for panos - #2633
Open
khackworth wants to merge 1 commit into
Open
khackworth wants to merge 1 commit into
khackworth wants to merge 1 commit into
Conversation
Python test results155 tests 155 ✅ 13s ⏱️ Results for commit 2882b77. ♻️ This comment has been updated with latest results. |
khackworth
force-pushed
the
PUC-2127_panos_ha_config
branch
from
November 6, 2026 15:09
89ee4a1 to
5851fdc
Compare
- Configure HA interfaces, peer-ip, group-id, and priority during inspection - Validate HA pairing bidirectionally when both nodes ready - Auto-transition both nodes to AVAILABLE state via Ironic RPC when validated - Add comprehensive pre-flight and post-config validation checks - Handle independent configuration (each device configures HA regardless of mate state) - Fully idempotent and backward compatible (only activates with HA traits + mate_serial) Fixes: PUC-2127
khackworth
force-pushed
the
PUC-2127_panos_ha_config
branch
from
November 6, 2026 15:19
5851fdc to
2882b77
Compare
khackworth
marked this pull request as ready for review
November 6, 2026 15:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
This will build the HA configuration on the Palo Altos early in its ironic lifecycle. The primary reason for this component moving forward into the
inspectprocess is that we need to identify cabling issues early before devices are deployed. Unfortunately, with these, there is no method to query the ha interfaces unless they are fully brought up (build the HA config). The NetSec standards for building HA devices, which has not changed for years, has been integrated into code. These items may be better handled as vars passed in from undercloud_deploy, but due to the static nature, I've placed in code here.Basic Discovery
HA Configuration (if has HA role trait)
HA Validation (if has mate_serial)
Auto-transition (if validation passed)
Exit States
--
Testing performed
Inspected a device WITHOUT a trait & with a mate_serial
Expected
inspected a device with a trait & without a mate_serial
inspected a device with a trait & with a mate_serial both properly configured
{ "extra": { "external_cmdb_id": 1354804, "serial": "026701009945", "mate_serial": "026701009584", "ha_configured": true, "ha_operational": true, "ha_peer_serial": "026701009584" }, "name": "PA-026701009945-kenny", "provision_state": "available", "traits": [ "CUSTOM_SECONDARY" ], "uuid": "7787db8b-ed9f-4713-8c13-df075903bc4f" }, { "extra": { "mate_serial": "026701009945", "external_cmdb_id": 1354803, "serial": "026701009584", "ha_operational": true, "ha_peer_serial": "026701009945" }, "name": "pa1410-dev-fw5", "provision_state": "available", "traits": [ "CUSTOM_PRIMARY" ], "uuid": "98fcc016-de95-47f8-bade-0c9b03bcb6a7" }What does this change do?
Upgrade impact
upgrade-impactlabel and a release note: runscriv createfrom therepository root and describe the required action in the generated
changelog.d/file. See RELEASING.md.Operator action means anything a deployment has to do beyond a normal resync:
deploy repo or values changes, new or removed secrets, enabling or disabling a
component, or a manual one-time step.