Skip to content

Only escape strings - #1446

Merged
royduin merged 2 commits into
masterfrom
bugfix/only-escape-text
Nov 4, 2026
Merged

royduin merged 2 commits into
masterfrom
bugfix/only-escape-text

Conversation

@indykoning

Copy link
Copy Markdown
Member

See: #1302 (comment)

We can trust that a carbon instance does not need escaping the way regular strings do.
But all the same if a value is truly a number/int, or a cast that may turn the data into an object we might run into errors by forcefully turning it into a string to escape.

The simplest solution is to check if it is a string before escaping, so carbon instances get passed. But any future instances will get passed without issue either.

Ref: RAP-2010

@indykoning
indykoning requested a review from royduin as a code owner November 2, 2026 10:58
@royduin
royduin merged commit e137eac into master Nov 4, 2026
25 of 26 checks passed
@royduin
royduin deleted the bugfix/only-escape-text branch November 4, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants