Repository navigation
Only escape strings - #1446
Merged
Merged
Only escape strings#1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #1302 (comment)
We can trust that a carbon instance does not need escaping the way regular strings do.
But all the same if a value is truly a number/int, or a cast that may turn the data into an object we might run into errors by forcefully turning it into a string to escape.
The simplest solution is to check if it is a string before escaping, so carbon instances get passed. But any future instances will get passed without issue either.
Ref: RAP-2010