Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
Member
|
I fixed it directly, the direction of the PR was a bit off (we should be storing a timestamp in the first place) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sort in
useFrecencySortingcompared the stored scores directly. Those scores are only decayed when the same item is visited again, so an item that was used a lot a long time ago kept outranking items used recently, and single visits always tied regardless of when they happened. This contradicts the documented behaviour ("the more recently an item is visited, the higher it will rank").This change moves the existing decay formula into
getDecayedFrecencyand uses it in both places: when a visit is recorded (unchanged behaviour) and in the comparator, where both scores are decayed to the samenowbefore being compared. The stored format is unchanged, so existing cached data keeps working.Tests: added
test/useFrecencySorting.test.tsxcovering an old visit vs a recent visit with the same score, many old visits vs a few recent ones (driven throughvisitItem), and frequency still winning when visits are equally recent. The first two fail on main and pass with this change.npm testandnpm run lintpass.Fixes #84