Add an experimental_onSafeAreaInsetsChange view prop - #58109
janicduplessis wants to merge 1 commit into
Conversation
ade05bd to
1973d38
Compare
014eb37 to
016438c
Compare
) Summary: `EventEmitter::experimental_flushSync` only *requests* an event beat; the beat is processed at the next `EventBeat::induce`. On iOS the run loop observer that induces the beat runs before Core Animation's commit observer, so a request made from `layoutSubviews` — inside CA's commit cycle — is only processed one frame later. Anything that reports layout-driven state to JS synchronously (`VirtualView` mode changes, and safe area insets in the PRs that build on this) renders a frame late in exactly the cases that matter. `AppleEventBeat` now also schedules an induce in the **display phase of the current commit cycle**. Core Animation runs a commit as layout → display → commit, so a zero-sized layer marked as needing display during layout gets its `display` call after the whole layout pass and before the transaction is committed. That layer needs to live in the tree being committed, so the beat has to know which tree that is — and the emitter tells it: - `experimental_flushSync` carries the **tag of the emitting view** through `EventDispatcher` and `EventQueue` to `EventBeat::requestSynchronous(Tag)`, with `kNoTag` (#58531) meaning no view attribution; a no-argument overload keeps unattributed requesters and the existing tests unchanged. The emitter reads the tag from its `ShadowNodeFamily` at flush time; `kNoTag` if the family is already gone. - `AppleEventBeat` resolves the tag to the layer of the view's **window** through a resolver injected by `RCTSurfacePresenter` (`findComponentViewWithTag:` on the mounting registry — nullable, non-creating, main thread) and attaches its flusher layer there. The requesting view's window is by definition the root of the layer tree whose layout emitted the request, so the flusher is guaranteed a display phase in the current commit cycle — including for content UIKit mounts in a window of its own, like a full screen modal or LogBox. Requests within one cycle coalesce into a single induce. One related fix in `EventBeat` itself: a synchronous request is no longer stranded behind an already-scheduled asynchronous beat (it would silently lose its this-frame guarantee, and the leftover flag would make an unrelated later beat blocking). `AppleEventBeat.cpp` becomes `.mm` for the Objective-C. **Risk:** this changes when queued events are flushed on iOS for every `experimental_flushSync` caller — today `VirtualView`, and safe area insets with the PRs on top. The worst case is a beat processed a frame *earlier* than before, inside a Core Animation commit; the run loop observer path is untouched and still catches anything the display phase misses (an emitter with no tag, an unmounted view, a request off the main thread). Android ignores the tag. Revert is self-contained. ## Design Q&A: **What happens when two views in different windows update at once?** Each requesting window gets its own dirty flusher layer (the map is keyed by host layer), and the first `display` to fire induces the beat, which drains the whole event queue — every window's updates mount before that commit presents. The remaining flushers hit the `isEventBeatRequested_` guard and no-op, so it is one beat total, not one per window. If windows ever commit in separate transactions, each request still resolves within its own window's cycle, since its layer sits in the tree that emitted it. Only requesting windows carry a dirty layer. **Can the tag point at the wrong view — after an unmount, or a recycled view?** No. The tag comes from the emitter's `ShadowNodeFamily`, and a family keeps one tag for its whole life, across clones and state updates; if the family is already gone the flush carries `kNoTag` and skips the resolver. What changes over a view's life — its window — is read live: the tag resolves to a view at flush time and `view.window.layer` is looked up then, so a view that moved between windows targets its current tree. A view mid-unmount or recycled resolves to nil (the registry erases the entry and recycled views get tag `0`) and degrades to run-loop-observer timing. The tag only ever influences *where the induce is scheduled*, never what is delivered or to whom, so the blast radius of any staleness is one frame of timing, not correctness. **Does `VirtualView` need changes to benefit?** No — its sync mode-change flush goes through its own emitter, so the tag attribution is automatic. The case this improves is a mode change emitted during Core Animation layout (a resize pulling a virtualized item into view): on `main` that renders one frame late; here the induce lands in the display phase of the VirtualView's own window, including inside a full screen modal. ## Changelog: [INTERNAL] - Process synchronous event beats in the frame that requested them on iOS, scheduling the induce on the requesting view's window Pull Request resolved: #58530 Test Plan: New unit tests in `EventBeatTest.cpp` cover the beat semantics: a synchronous request during an already-scheduled asynchronous beat, coalescing, and induce ordering. They drive the protected `induce` through a subclass standing in for the platform. On device, with the safe area insets prop from the PRs above merged on top: an RNTester example renders a loud marker (yellow background) while a view observes the safe area but has not received an inset event yet, so any presented marker frame means the dispatch was not synchronous. The full apply → landscape → portrait sequence **inside a full screen modal** on an iPhone 17 Pro simulator, decomposed with ffmpeg into 982 frames and every frame scanned for the marker color — **zero marker frames**, and mid-rotation frames already carry the incoming orientation's insets, so the padding animates with the rotation. Scoped honestly: the first inset event after setting the prop is processed at the call site, so the marker primarily proves no regression; the same-frame path for layout-driven changes rests on the by-construction argument above plus the rotation frames. https://github.com/user-attachments/assets/0f2db837-c9c0-4457-96c2-847b7aecf10e `yarn fantom .../ViewSafeAreaInsets-itest.js` passes 4/4 with the prop merged on top. C++ API snapshots regenerated (`scripts/cxx-api/parser`, Doxygen 1.16.1): the deltas are the `requestSynchronous` overload pair, `EventEmitter::getTag`, the resolver type, and the `AppleEventBeat` constructor and destructor. --- **Stack** — split out of #57967, which stays open as the prototype and design discussion. GitHub will not take a fork branch as a pull request base, so each of these targets `main` and its diff contains the ones below it until they merge. Each PR is one commit on top of the previous one. This is the bottom of the stack, so its diff is already just this change. 👉 1. #58530 — Process synchronous event beats in the frame that requested them 2. #58109 — Add an `experimental_onSafeAreaInsetsChange` view prop 3. #58110 — Report the window safe area insets through Dimensions 4. #58112 — Render the internal SafeAreaView from the safe area insets prop 5. #58113 — Remove the native SafeAreaView and the deprecated public export An earlier variant that targeted the surface's root view instead of the view's window was closed in #58528; its review thread carries the analysis behind the window-based resolution. #58108 was the per-window predecessor this supersedes. Reviewed By: javache Differential Revision: D120200496 Pulled By: Abbondanzo fbshipit-source-id: b06ecb30935837abd6561f54674afef0cdf215a8
016438c to
62b86aa
Compare
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D121015233. |
43adb2a to
f5d8d36
Compare
|
Re-ran the device checks from the test plan on this commit (f5d8d36, since rebased onto current main as 60dae49 — sentinel ivar, Android first-emit deferred to pre-draw, insets-only payload). iPhone 17 Pro simulator and an Android 16 emulator. The Android column is the one to look at: its first emit now goes through the pre-draw listener instead of the prop setter, and rotation was the one case the prototype never exercised. A view inside the safe area reads zero insets
Full screen view padded by its own insets — the pink (unpadded) area lines up with the system UIPortrait, then landscape; in landscape the top inset follows the notch / status bar to the side, and the portrait values read back correctly after rotating back.
The iOS landscape capture is from a build with #58632 applied: re-taking it showed the readout text clipped at its previous width after rotation — a stale paragraph drawing frame when the mount runs in the display phase, which that standalone PR fixes. Synchronous dispatch, frame by frameApply insets → rotate → rotate back. The example shows a yellow marker while a view observes the safe area but has not received an inset event yet, so any presented marker frame means the dispatch was not synchronous. Every frame of each recording was scanned for the marker color. iOS — 828 frames, rotations at frames 194 and 523, 0 marker frames marker.mp4Android — 194 frames, rotations at frames 107 and 183, 0 marker frames a-marker.mp4Loop warningThe example's deliberately mispositioned view (offset by the insets it reports) loops; LogBox shows one warning and it stays at one.
Two things worth knowing. The loop runs at a few thousand events/s on iOS but a few hundred on Android — Android's is bounded by the pre-draw cadence (one emit per frame), iOS's re-layout cycles faster; both are well past the warning threshold. And the Android recording is a 216×480 downscale from the tool, coarser than the iOS one, but the modal's pink background is clearly detectable at that size (7,400 px in a mid frame), so the yellow marker — a larger, more saturated block — would have been too; the zero is real. |
ef1eb75 to
60dae49
Compare
Reports the part of a view that is covered by the system UI, as a view prop:
```jsx
<View
experimental_onSafeAreaInsetsChange={({nativeEvent: {insets}}) => {
// insets: {top, right, bottom, left}
}}
/>
```
`SafeAreaView` is deprecated in favour of `react-native-safe-area-context`,
but core surfaces like LogBox and the element inspector cannot depend on the
library, so core keeps a private copy of the deprecated component alive. The
smallest primitive that lets both sides go away is native code reporting
inset values to JavaScript — today the library's own `RNCSafeAreaProvider`
component. This adds that primitive, with the payload the library already
uses, so `SafeAreaProvider` can swap its native component for a plain `View`.
Insets are relative to the view: one laid out inside the safe area reports
zeros. That is what makes the prop composable and stops nested providers
from double-padding.
**Cost when unused.** The prop is a `bool` in `BaseViewProps`, like
`onLayout`; native only observes the safe area when it is set. On iOS the
flag is read from the props the view already holds and the last-sent insets
are a plain `UIEdgeInsets` ivar (a negative sentinel marks "none sent yet",
since insets are never negative); the only unconditional cost is a branch in
`layoutSubviews`,
`didMoveToWindow` and `safeAreaInsetsDidChange`.
**Cost when used.** Events fire only when the *insets* change, so a view
moving inside a scroll view emits nothing, and 50 observing rows scroll at the same frame times as
zero. An observing view allocates nothing per frame on Android in the steady
state. Benchmarked with the "Scroll benchmark" section of the new RNTester
example.
**Synchronous dispatch.** The event goes out through
`EventEmitter::experimental_flushSync` as a `Discrete` event, so inset-driven
layout is mounted in the frame the insets changed in — first mount included,
and on rotation the padding animates with the transition instead of jumping
after it.
Edge cases covered: view flattening (the prop forms a stacking context so
the host view cannot be optimized away), view recycling on both platforms,
Android views fully clipped by an ancestor, and multi-window iPad.
Folded in from review: the prop is forwarded through BaseViewManagerDelegate
for components with generated delegates, and the event is exported from the
native view config so it maps to the handler when native view configs are
in use.
Development warning for a view that reports its insets in a loop:
The system UI does not move many times a second, so a sustained stream of
inset events means the layout is feeding the insets back into the position of
the observed view: it is offset by the insets it reports, which moves it out
from under the system UI, which changes its insets. Every one of those events
renders synchronously, so the loop is paid for in frames.
`View` wraps the handler in development builds and warns once per view above
ten events in a second. The check lives in the handler `View` passes down
rather than in either platform's observer, so it covers iOS and Android with
one implementation and surfaces in LogBox with a JavaScript stack.
The production branch is the identity function, so the module stays out of
the bundle, and the native prop is unaffected either way — function props are
normalized to `true` before props are diffed, so wrapping does not produce an
update. Counts are kept per view in a `WeakMap` keyed by the event target, so
views that do not loop are never charged for it.
RNTester grows the mistake it warns about, and a Fantom test with a mocked
clock covers the rate, the once-per-view behaviour, per-view counting, and
that the handler still receives its event.
The payload is the insets alone. A frame is deliberately not included: it
would only be current as of the last inset change, since the trigger is
inset-only, and reporting it needs a coordinate space that differs between
platforms (the enclosing view controller on iOS, the window on Android). A
view that needs its own frame has `onLayout` and `measureInWindow`, which
stay current; the window's frame is in `Dimensions`.
60dae49 to
07fcf31
Compare








Summary:
Reports the part of a view that is covered by the system UI, as a view prop:
SafeAreaViewis deprecated in favour ofreact-native-safe-area-context(react-native-community/discussions-and-proposals#827), but core surfaces like LogBox and the element inspector cannot depend on the library, so core keeps a private copy of the deprecated component alive. The smallest primitive that lets both sides go away is native code reporting inset values to JavaScript — today the library's ownRNCSafeAreaProvidercomponent. This adds that primitive as a view prop, soSafeAreaProvidercan swap its native component for a plainView.Insets are relative to the view: one laid out inside the safe area reports zeros. That is what makes the prop composable and stops nested providers from double-padding.
The event is dispatched synchronously through
experimental_flushSync, so the layout that depends on the insets is mounted in the frame the insets changed in (on iOS that relies on #58530 for events emitted fromlayoutSubviews; text re-rendered by them draws correctly once #58632 lands). A full inset event — dispatch, JS render, commit, mount — is about 3 ms in a debug build re-rendering a small component, paid per inset change rather than per frame.Two things I'd like input on:
boolinBaseViewPropslikeonLayout, and a branch on it inlayoutSubviews,didMoveToWindowandsafeAreaInsetsDidChangeon every view. Worth a look from someone who profiles that path. On Android nothing is attached unless the prop is set.In development,
Viewwraps the handler and warns once per view above ten events in a second. The system UI does not move that often, so a sustained stream means the layout is feeding the insets back into the view's own position — offset by what it reports, it moves out from under the system UI, which changes what it reports. The check is one JavaScript implementation for both platforms and surfaces in LogBox with a stack rather than in logcat.Changelog:
[GENERAL] [ADDED] - Add an
experimental_onSafeAreaInsetsChangeview prop, reporting the part of a view that is covered by the system UI, with a development warning for views that report their insets in a loopTest Plan:
RNTester, new "Safe area insets" example, on an iPhone 17 Pro simulator and an Android 16 emulator: a view inside the safe area reads zero insets; a full screen view padding itself by its own insets lines up with the system UI in portrait and landscape on both platforms; the scroll benchmark counts events on both platforms. Screenshots and the synchronous-dispatch frame captures are in #57967, the prototype this splits. The example also grows the mistake the warning catches — a view positioned by the insets it reports — behind a button, and it logs once.
Fantom (
ViewSafeAreaInsets-itest.js,ViewSafeAreaInsetsWarning-itest.js):On device:
ScrollViewemit nothing instead of garbage overlap values (event counters in the scroll benchmark).UIApplicationSupportsMultipleScenesenabled in a local RNTester build (it ships off): two windows, two React instances, one shared key window, correct per-window insets across tiling, fullscreen, rotation and keyboard.Known gaps, not addressed here:
FabricUIManager's per-frame synchronous-event dedupe can drop a second inset change for the same view within one frame; in practice insets don't change twice per frame.getGlobalVisibleRectmixes coordinate spaces for partially clipped views, inherited from the library's implementation.layoutSubviewsfor the next transaction, so its event lands a frame late. It needs one observer's synchronous render to resize a second observer; I have not hit it.View. The prop is onBaseViewProps, soText,ImageandScrollViewaccept it too;Viewis where it is used in practice.Stack — split out of #57967, which stays open as the prototype and design discussion. GitHub will not take a fork branch as a pull request base, so each of these targets
mainand its diff contains the ones below it until they merge. Each PR is one commit on top of the previous one. The display-phase event beat this builds on landed as #58530. #58632 is a standalone fix for text drawn from a display-phase mount, which the prop exposes on rotation.This is the bottom of the stack, so its diff is already just this change.
👉 1. #58109 — Add an
experimental_onSafeAreaInsetsChangeview prop2. #58110 — Report the window safe area insets through Dimensions
3. #58112 — Render the internal SafeAreaView from the safe area insets prop
4. #58113 — Remove the native SafeAreaView and the deprecated public export