Skip to content

Use public umbrellas in scrollview headers - #58640

Open
coado wants to merge 3 commits into
react:mainfrom
coado:export-D121191600
Open

coado wants to merge 3 commits into
react:mainfrom
coado:export-D121191600

Conversation

@coado

@coado coado commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary:
Route ScrollView framework header dependencies through their supported public umbrella entry points while preserving the module's framework-tier classification. Add direct standard-library and graphics includes where the exported declarations would otherwise rely on transitive coverage.

Changelog: [Internal]

Differential Revision: D121191600

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 22, 2026
@coado
coado force-pushed the export-D121191600 branch 2 times, most recently from d3bff45 to aa5f107 Compare September 22, 2026 15:20
Summary:

Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled.

Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers.

Changelog:
[Internal]

Reviewed By: cortinico

Differential Revision: D120532145
Summary:
Route public React Native dependencies in exported TextInput framework headers through their supported umbrella headers. Preserve fine-grained includes for same-target, framework-tier, graphics, and third-party dependencies.

Changelog:
[Internal]

Reviewed By: cipolleschi

Differential Revision: D120677815
Summary:
Route ScrollView framework header dependencies through their supported public umbrella entry points while preserving the module's framework-tier classification. Add direct standard-library and graphics includes where the exported declarations would otherwise rely on transitive coverage.

Changelog: [Internal]

Differential Revision: D121191600

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant