DynamicRangeCompressor settings are not restored automatically on video playback (only applied when opening dialog) #3237

Steps to reproduce

1. Enable the Dynamic Range Compressor setting in CloudStream Player Settings.
2. Play any video in the player and turn ON the compressor in the compressor dialog (or apply a preset).
3. Close the player or play another episode/video.
4. Listen to the audio during playback: the compressor is NOT active (dialogues are quiet, volume spikes are untamed).
5. Tap the screen to reveal player controls and tap the Compressor button (playerCompressorBtt) to open the compressor dialog.
6. The exact instant the dialog opens, the compressor immediately kicks in and the audio becomes compressed / boosted.

Expected behavior

When DynamicRangeCompressor has been enabled by the user, newly played videos should automatically restore and activate the compressor settings upon playback initialization without requiring the user to tap the screen and open the compressor dialog manually.

Actual behavior

Every newly started video plays with DynamicRangeCompressor.enabled = false. It is only switched to enabled = true when the user manually taps the compressor button to open showCompressorDialog().

Cloudstream version and commit hash

Pre-release / master branch (Commit 4e2516d / PR #3117)

Android version

Android 12+ (All versions, TV and Phone)

Logcat

N/A (Functional lifecycle timing issue in player initialization)

Other details

Root Cause Analysis

In app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt:

restoreCompressorSettings() is only called in two locations:

1. In onBindingCreated():

playerBinding?.apply {
    playerSpeedBtt.isVisible = playBackSpeedEnabled
    playerCompressorBtt.isVisible = playBackCompressorEnabled
    if (playBackCompressorEnabled) {
        restoreCompressorSettings()
    }
    ...

2. In showCompressorDialog():

private fun showCompressorDialog() {
    val act = activity ?: return
    val compressor = (player as? CS3IPlayer)?.compressor ?: return

    // Always restore — CS3IPlayer is recreated between videos
    restoreCompressorSettings()
    ...

Inside restoreCompressorSettings():

protected fun restoreCompressorSettings() {
    val c = (player as? CS3IPlayer)?.compressor ?: return
    c.enabled     = getKey(COMPRESSOR_ENABLED_KEY)   ?: false
    c.threshold   = getKey(COMPRESSOR_THRESHOLD_KEY) ?: -24f
    c.ratio       = getKey(COMPRESSOR_RATIO_KEY)     ?: 8f
    c.attackMs    = getKey(COMPRESSOR_ATTACK_KEY)    ?: 5f
    c.releaseMs   = getKey(COMPRESSOR_RELEASE_KEY)   ?: 400f
    c.makeupGain  = getKey(COMPRESSOR_MAKEUP_KEY)    ?: 12f
}

The Bug:
When onBindingCreated() runs, the media stream has not yet started loading and ExoPlayer has not yet built its renderers. Therefore, (player as? CS3IPlayer)?.compressor is still null.
As a result, val c = (player as? CS3IPlayer)?.compressor ?: return immediately returns without doing anything.

Later, when CS3IPlayer.load() executes and builds ExoPlayer, a new instance of DynamicRangeCompressor is created. In DynamicRangeCompressor.kt:

@Volatile var enabled: Boolean = false

The compressor is initialized with enabled = false. Because restoreCompressorSettings() is never called again after load(), the compressor remains OFF throughout playback.

When the user manually taps the compressor button while the video is playing, showCompressorDialog() is invoked. At that point, compressor is no longer null, so restoreCompressorSettings() finally runs and turns c.enabled = true.

Suggested Fix

Call restoreCompressorSettings() once the player / renderers are actually initialized (e.g. inside CS3IPlayer.load() after creating DynamicRangeCompressor, or on Player.Listener.onPlaybackStateChanged / onRenderedFirstFrame in FullScreenPlayer).

Alternatively, pass the initial enabled state and saved values from DataStore directly into DynamicRangeCompressor's constructor or factory when CS3IPlayer creates it in setRenderersFactory.

Acknowledgements

• I am sure my issue is related to the app and NOT some extension.
• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
• I have written a short but informative title.
• I have updated the app to pre-release version Latest.
• I will fill out all of the requested information in this form.