Repository navigation
Match class names case-insensitively in lookup keys - #50
Merged
Merged
Conversation
PHP class names are case-insensitive, so new foo(1) for class Foo or use App\foo must hit the same entry. Lowercase the class part of the aggregate, symbols and inherit keys via phpast.ClassKey, keep the written case in added type text, and drop duplicate object types that differ only in case.
TomasVotruba
force-pushed
the
case-insensitive-class-names
branch
from
November 14, 2026 19:58
9194b5f to
59df5ac
Compare
TomasVotruba
enabled auto-merge (squash)
November 14, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP class names are case-insensitive, but lookups matched them case-sensitively, so
new foo(1)forclass Foooruse App\foomissed.phpast.ClassKeyand lowercase the class part of keys in aggregate, symbols (enums, class consts) and inherit (classes, parents, interfaces)\Foo|\foounion